Skip to content

feat: improve docker-compose generation with restart, depends_on, network, and zmq mode#550

Closed
Sahil-u07 wants to merge 10 commits into
ControlCore-Project:devfrom
Sahil-u07:improve-docker-compose
Closed

feat: improve docker-compose generation with restart, depends_on, network, and zmq mode#550
Sahil-u07 wants to merge 10 commits into
ControlCore-Project:devfrom
Sahil-u07:improve-docker-compose

Conversation

@Sahil-u07
Copy link
Copy Markdown
Contributor

The existing --compose flag generated a bare docker-compose.yml with
only image: and volumes: per service. This improves it with four
additions: restart: on-failure on every service so node startup
races don't permanently fail, sequential depends_on wiring between
services, a shared concore_net bridge network, and an optional
--zmq flag that injects CONCORE_TRANSPORT=zmq for studies using
the ZMQ transport layer.

Also adds a console warning when --compose is used but no docker
run script exists yet, replacing the previous silent None return.

8 regression tests added in tests/test_compose_generation.py,
all testing _write_docker_compose() directly without subprocess

Copilot AI review requested due to automatic review settings May 17, 2026 20:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@Sahil-u07 Sahil-u07 force-pushed the improve-docker-compose branch from 6d4aff0 to 88bd2e0 Compare May 17, 2026 20:51
@Sahil-u07 Sahil-u07 force-pushed the improve-docker-compose branch from 88bd2e0 to 90a1e83 Compare May 17, 2026 21:00
@Sahil-u07 Sahil-u07 closed this May 17, 2026
@Sahil-u07 Sahil-u07 deleted the improve-docker-compose branch May 17, 2026 21:07
@Sahil-u07 Sahil-u07 restored the improve-docker-compose branch May 17, 2026 21:08
@Sahil-u07 Sahil-u07 deleted the improve-docker-compose branch May 17, 2026 21:09
@Sahil-u07 Sahil-u07 restored the improve-docker-compose branch May 17, 2026 21:13
@Sahil-u07 Sahil-u07 deleted the improve-docker-compose branch May 17, 2026 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants