Skip to content

Implement conditional dependency copying to prevent empty script generation#430

Closed
GREENRAT-K405 wants to merge 1 commit into
ControlCore-Project:devfrom
GREENRAT-K405:fix/missing-script-flaws
Closed

Implement conditional dependency copying to prevent empty script generation#430
GREENRAT-K405 wants to merge 1 commit into
ControlCore-Project:devfrom
GREENRAT-K405:fix/missing-script-flaws

Conversation

@GREENRAT-K405
Copy link
Copy Markdown
Contributor

changes made:

  • Added a pre-processing loop that iterates over nodes_dict to extract and store the required file extensions in a required_langs set
  • Wrapped the dependency copying logic for Python, C++, Verilog, and MATLAB/Octave (including the mkcompile script) inside conditional if statements. The script now only attempts to locate and copy protocol files if that specific language is present in the graphml structure

this fixes #429

@GREENRAT-K405
Copy link
Copy Markdown
Contributor Author

don't know why but github is showing inaccurate delta (Around 300 changes), my actual number of code line changes are around ~100 lines only and other lines aren't even touched.

@GREENRAT-K405
Copy link
Copy Markdown
Contributor Author

@pradeeban please have a look at the solution (around line 550-640).

@GREENRAT-K405
Copy link
Copy Markdown
Contributor Author

GREENRAT-K405 commented Feb 20, 2026

@pradeeban
One additional question regarding project idea:

If we follow a julia first approach, we should technically replace mkconcore.py (our orchestrator) with mkconcore.jl?

But since it is just an orchestrator code, changing it to jl might not be of much benefit.

Why I felt this question was important to ask :

  • Do we "replace" python first approach of concore with a julia first approach or do we just add support for julia concore programs?
  • because, if we plan on replacing mkconcore.py with mkconcore.jl, it will be one of the major end outcomes of the project

@pradeeban
Copy link
Copy Markdown
Member

@GREENRAT-K405 Looks like a lot of line changes even when there is no real change. Perhaps an EoL character is changed? Can you pls recreate the PR with minimal changes to the file (the least number of line changes absolutely necessary)?

That will help with the PR review and code maintenance and ownership (now, with all these line changes, when a bug appears in a line, it will point to you even if you did not really change that line).

@GREENRAT-K405
Copy link
Copy Markdown
Contributor Author

will fix that ASAP!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants