Implement conditional dependency copying to prevent empty script generation#430
Implement conditional dependency copying to prevent empty script generation#430GREENRAT-K405 wants to merge 1 commit into
Conversation
|
don't know why but github is showing inaccurate delta (Around 300 changes), my actual number of code line changes are around ~100 lines only and other lines aren't even touched. |
|
@pradeeban please have a look at the solution (around line 550-640). |
|
@pradeeban If we follow a julia first approach, we should technically replace mkconcore.py (our orchestrator) with mkconcore.jl? But since it is just an orchestrator code, changing it to jl might not be of much benefit. Why I felt this question was important to ask :
|
|
@GREENRAT-K405 Looks like a lot of line changes even when there is no real change. Perhaps an EoL character is changed? Can you pls recreate the PR with minimal changes to the file (the least number of line changes absolutely necessary)? That will help with the PR review and code maintenance and ownership (now, with all these line changes, when a bug appears in a line, it will point to you even if you did not really change that line). |
|
will fix that ASAP! |
changes made:
this fixes #429