use named logger, drop force=True#411
Merged
pradeeban merged 1 commit intoFeb 19, 2026
Merged
Conversation
Contributor
Author
|
hey @pradeeban noticed this while poking around the codebase (quick fix) While looking at this I also noticed a few other py/cpp/java inconsistencies along the same lines (type mismatches, default handling etc). Happy to audit those too or if there's a higher-priority area you'd rather I dig into first, just point me there. I would love your suggestions (just like you trained me how to tackle merge conflicts lol) |
Member
|
Don't worry too much about the inconsistencies at this point. There are many. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced root logger config with
logging.getLogger('concore')+NullHandler(). Theforce=Truewas nuking any logging setup done before importing concore, which breaks apps using it as a libraryChanged all
logging.info/error/warning/debugcalls to use the named logger instead.Fixes #410