Skip to content

use named logger, drop force=True#411

Merged
pradeeban merged 1 commit into
ControlCore-Project:devfrom
avinxshKD:fix/logging-nullhandler
Feb 19, 2026
Merged

use named logger, drop force=True#411
pradeeban merged 1 commit into
ControlCore-Project:devfrom
avinxshKD:fix/logging-nullhandler

Conversation

@avinxshKD
Copy link
Copy Markdown
Contributor

Replaced root logger config with logging.getLogger('concore') + NullHandler(). The force=True was nuking any logging setup done before importing concore, which breaks apps using it as a library

Changed all logging.info/error/warning/debug calls to use the named logger instead.

Fixes #410

@avinxshKD
Copy link
Copy Markdown
Contributor Author

hey @pradeeban noticed this while poking around the codebase (quick fix)

While looking at this I also noticed a few other py/cpp/java inconsistencies along the same lines (type mismatches, default handling etc). Happy to audit those too or if there's a higher-priority area you'd rather I dig into first, just point me there. I would love your suggestions (just like you trained me how to tackle merge conflicts lol)

@pradeeban
Copy link
Copy Markdown
Member

Don't worry too much about the inconsistencies at this point. There are many.

@pradeeban pradeeban merged commit de5c3e4 into ControlCore-Project:dev Feb 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants