Skip to content

security: prevent command injection in /contribute endpoint by removing shell=True (fixes #360) #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pradeeban merged 1 commit into from
Feb 19, 2026
Merged

security: prevent command injection in /contribute endpoint by removing shell=True (fixes #360) #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions fri/server/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,16 +396,18 @@ def contribute():
validate_text_field(PR_TITLE, 'title', max_length=512)
validate_text_field(PR_BODY, 'desc', max_length=8192)

# Build base command depending on platform
if(platform.uname()[0]=='Windows'):
# Use cmd.exe /c to invoke contribute.bat on Windows
proc = subprocess.run(["cmd.exe", "/c", "contribute.bat", STUDY_NAME, STUDY_NAME_PATH, AUTHOR_NAME, BRANCH_NAME, PR_TITLE, PR_BODY], cwd=concore_path, check=True, capture_output=True, text=True)
output_string = proc.stdout
cmd = ["cmd.exe", "/c", "contribute.bat", STUDY_NAME, STUDY_NAME_PATH, AUTHOR_NAME]
else:
if len(BRANCH_NAME)==0:
proc = check_output([r"./contribute",STUDY_NAME,STUDY_NAME_PATH,AUTHOR_NAME],cwd=concore_path)
else:
proc = check_output([r"./contribute",STUDY_NAME,STUDY_NAME_PATH,AUTHOR_NAME,BRANCH_NAME,PR_TITLE,PR_BODY],cwd=concore_path)
output_string = proc.decode()
cmd = [r"./contribute", STUDY_NAME, STUDY_NAME_PATH, AUTHOR_NAME]

# Append optional branch/PR args only when BRANCH_NAME is provided
if len(BRANCH_NAME) > 0:
cmd.extend([BRANCH_NAME, PR_TITLE, PR_BODY])

proc = subprocess.run(cmd, cwd=concore_path, check=True, capture_output=True, text=True)
output_string = proc.stdout
status=200
if output_string.find("/pulls/")!=-1:
status=200
Expand Down