fix: remove hardcoded sudo docker and respect DOCKEREXE override in mkconcore.py (fixes #343)#400
Closed
GaneshPatil7517 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #343 by removing the hardcoded "sudo docker" default in mkconcore.py and ensuring the configured Docker command (DOCKEREXE) is used consistently when generating helper scripts.
Changes:
- Change the default Docker command from
"sudo docker"toos.environ.get("DOCKEREXE", "docker"). - Keep existing precedence where
concore.sudo(if present) overrides the environment/default value. - Update generated
maxtime,params, andunlockscripts to useDOCKEREXEinstead of hardcoded"sudo docker".
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Looks like a lot of lines are changed (perhaps a change in linebreak/EoL character), when the actual change is fewer lines. Can you please re-create the PR with just the necessary minimal line changes? |
Contributor
Author
|
ok @pradeeban Sir give me few minutes ....... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves Issue #343 by removing hardcoded
"sudo docker"usage inmkconcore.pyand ensuring theDOCKEREXEconfiguration is respected consistently.Problem
mkconcore.pydefaulted to"sudo docker", which fails on:maxtime,params, andunlockscripts all hardcoded"sudo docker"instead of using theDOCKEREXEvariableChanges Made
"sudo docker"toos.environ.get("DOCKEREXE", "docker")— defaults to"docker", overridable via environment variableconcore.sudoexists, it overridesDOCKEREXEas before"sudo docker"occurrences inmaxtime,params, andunlockscript generation replaced with f-string{DOCKEREXE}referencesBenefits
DOCKEREXE=podman)concore.sudoBackward Compatibility
Users who previously relied on the default
sudo dockerbehavior can restore it by either:DOCKEREXE="sudo docker"environment variableconcore.sudoconfig file (unchanged behavior)Scope
mkconcore.pyTesting
docker, env override works,concore.sudooverride works, no hardcoded sudo in generated scripts