Fix: add missing return after ZMQ send in write() - Fixes #238#242
Merged
pradeeban merged 1 commit intoFeb 11, 2026
Merged
Conversation
Contributor
Author
|
@pradeeban the failing tests don't seem related to this change. The fix just adds a single return statement after ZMQ, doesn't touch imports or CLI logic. |
Member
|
Yep, the tests are useless right now with something that is fundamentally broken. Have to look at that separately. Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #238
The write() function was missing a return statement after the ZMQ send path, causing execution to fall through into the file-based write logic. This led to redundant file operations after every ZMQ write.
Added return to match the pattern already used in read()