fix: SET_FUNCTIONS was mutating the graph object in-place#337
Merged
pradeeban merged 1 commit intoFeb 23, 2026
Merged
Conversation
Author
|
Hey @pradeeban tested build/run/stop, buttons update fine now. lmk if anything looks off still working on concore watch for live simulation, will let you know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shallow copy means newState.graphs[curGraphIndex] is still the same ref, React skips the re-render, toolbar buttons don't update after server actions.
Fixed by using .map() like every other case that touches a graph (SET_FILE_HANDLE, SET_AUTHOR, etc..
Closes #335