Skip to content

🎨 Palette: [μ ‘κ·Όμ„± κ°œμ„ ] 정적 μš”μ†Œμ˜ λΆˆν•„μš”ν•œ tabIndex 제거#476

Closed
seonghobae wants to merge 2 commits into
mainfrom
palette/remove-tabindex-static-elements-9858909559568915730
Closed

🎨 Palette: [μ ‘κ·Όμ„± κ°œμ„ ] 정적 μš”μ†Œμ˜ λΆˆν•„μš”ν•œ tabIndex 제거#476
seonghobae wants to merge 2 commits into
mainfrom
palette/remove-tabindex-static-elements-9858909559568915730

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What:
frontend/src/erd/TableNode.tsx의 AccessibleTruncatedText μ»΄ν¬λ„ŒνŠΈμ™€ 일뢀 정적 μ•Œλ¦Ό 문ꡬ("μƒλž΅λœ 컬럼이 더 μžˆμŠ΅λ‹ˆλ‹€", "μƒλž΅λœ μΈλ±μŠ€κ°€ 더 μžˆμŠ΅λ‹ˆλ‹€")μ—μ„œ tabIndex={0} 속성을 μ œκ±°ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why:
λ‹¨μˆœνžˆ titleμ΄λ‚˜ aria-label을 ν‚€λ³΄λ“œ μ‚¬μš©μžμ—κ²Œ λ…ΈμΆœμ‹œν‚€κΈ° μœ„ν•΄ λΉ„μƒν˜Έμž‘μš©μ (static) μš”μ†Œμ— tabIndex={0}λ₯Ό μΆ”κ°€ν•˜λŠ” 것은 μ ‘κ·Όμ„± μ•ˆν‹°νŒ¨ν„΄μž…λ‹ˆλ‹€. μ΄λŠ” λΆˆν•„μš”ν•˜κ²Œ λ§Žμ€ νƒ­ μŠ€ν†±μ„ μƒμ„±ν•˜μ—¬ ν‚€λ³΄λ“œλ‘œ λ„€λΉ„κ²Œμ΄μ…˜ν•˜λŠ” μ‚¬μš©μžλ“€μ˜ κ²½ν—˜μ„ 크게 μ €ν•˜μ‹œν‚΅λ‹ˆλ‹€.

πŸ“Έ Before/After:

  • Before: ν…Œμ΄λΈ” λ‚΄μ˜ λ‹¨μˆœ 컬럼 주석, κ·Έλ£Ή 이름, μƒλž΅ ν‘œμ‹œ(β€œβ€¦ N more”) 등이 λͺ¨λ‘ νƒ­ μŠ€ν†±μœΌλ‘œ μž‘ν˜€ νƒ­ ν‚€ 이동이 맀우 λΉ„νš¨μœ¨μ μ΄μ—ˆμŠ΅λ‹ˆλ‹€.
  • After: μ‹€μ œλ‘œ μƒν˜Έμž‘μš© κ°€λŠ₯ν•œ μš”μ†Œλ“€λ§Œ νƒ­ μŠ€ν†±μœΌλ‘œ 작히며, 뢀가적인 ν…μŠ€νŠΈ μ •λ³΄λŠ” 슀크린 리더가 DOM 탐색 μ‹œ μžμ—°μŠ€λŸ½κ²Œ 읽을 수 μžˆλ„λ‘ μ ‘κ·Όμ„± 속성(aria-label, title)만 μœ μ§€λ©λ‹ˆλ‹€.

β™Ώ Accessibility:

  • ν‚€λ³΄λ“œ λ„€λΉ„κ²Œμ΄μ…˜ 흐름 μ΅œμ ν™” (λΆˆν•„μš”ν•œ νƒ­ μŠ€ν†± 제거)
  • λΉ„μƒν˜Έμž‘μš©μ  μš”μ†Œμ˜ 포컀슀 문제 ν•΄κ²°

PR created automatically by Jules for task 9858909559568915730 started by @seonghobae

정적 μš”μ†Œ(예: span)에 λΆ€μ—¬λœ λΆˆν•„μš”ν•œ `tabIndex={0}`λ₯Ό μ œκ±°ν•˜μ—¬ 슀크린 리더 및 ν‚€λ³΄λ“œ μ‚¬μš©μžμ˜ 탐색 κ²½ν—˜μ„ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@opencode-agent

opencode-agent Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 080dae446083cf5d8f0695296663ac1b5ebe86c4
  • Workflow run: 28762386863
  • Workflow attempt: 1
  • Gate result: APPROVE (exit 0)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file: palette.md"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file: palette.md"]
  R1 --> V1["required checks"]
  Evidence --> S2["Frontend (2 files)"]
  S2 --> I2["browser runtime and bundle"]
  I2 --> R2["Review risk: Frontend (2 files)"]
  R2 --> V2["frontend tests"]
Loading

정적 μš”μ†Œ(예: span)에 λΆ€μ—¬λœ λΆˆν•„μš”ν•œ `tabIndex={0}`λ₯Ό μ œκ±°ν•˜μ—¬ 슀크린 리더 및 ν‚€λ³΄λ“œ μ‚¬μš©μžμ˜ 탐색 κ²½ν—˜μ„ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
@seonghobae seonghobae enabled auto-merge (squash) July 6, 2026 23:22
@seonghobae seonghobae disabled auto-merge July 7, 2026 00:04
@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing during org-wide PR backlog reduction. This looks like a low-priority automated maintenance PR (palette ux/a11y), while the repository has a large backlog of security, conflict, and required-workflow work. Reopen or recreate a fresh PR if this change is still needed.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing during org-wide PR backlog reduction. This looks like a low-priority automated maintenance PR (palette ux/a11y), while the repository has a large backlog of security, conflict, and required-workflow work. Reopen or recreate a fresh PR if this change is still needed.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant