Skip to content

๐Ÿ›ก๏ธ Sentinel: [HIGH] ์ตœ์ƒ์œ„ ๋””๋ ‰ํ† ๋ฆฌ ์‹ฌ๋ณผ๋ฆญ ๋งํฌ ์šฐํšŒ ์ทจ์•ฝ์  ์ˆ˜์ •#104

Closed
seonghobae wants to merge 2 commits into
masterfrom
sentinel-fix-symlink-traversal-8396158036172354303
Closed

๐Ÿ›ก๏ธ Sentinel: [HIGH] ์ตœ์ƒ์œ„ ๋””๋ ‰ํ† ๋ฆฌ ์‹ฌ๋ณผ๋ฆญ ๋งํฌ ์šฐํšŒ ์ทจ์•ฝ์  ์ˆ˜์ •#104
seonghobae wants to merge 2 commits into
masterfrom
sentinel-fix-symlink-traversal-8396158036172354303

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿšจ Severity: HIGH
๐Ÿ’ก Vulnerability: File.canonicalFile์ด ์‹ฌ๋ณผ๋ฆญ ๋งํฌ๋ฅผ ๋ฏธ๋ฆฌ ํ•ด์„ํ•˜์—ฌ, Files.isDirectory์˜ NOFOLLOW_LINKS ์˜ต์…˜์„ ์šฐํšŒํ•˜๊ณ  ์˜๋„์น˜ ์•Š์€ ์‹œ์Šคํ…œ ๊ฒฝ๋กœ์˜ ํŒŒ์ผ์„ ์ฝ์„ ์ˆ˜ ์žˆ๋Š” ๊ฒฝ๋กœ ํƒ์ƒ‰(Path Traversal) ์ทจ์•ฝ์ ์ด ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Impact: ๊ณต๊ฒฉ์ž๊ฐ€ ์ƒŒ๋“œ๋ฐ•์Šค๋ฅผ ์šฐํšŒํ•˜๊ณ  ์‹œ์Šคํ…œ์˜ ์ž„์˜ ๋””๋ ‰ํ† ๋ฆฌ ๊ตฌ์กฐ๋ฅผ ์ฝ์–ด ์ •๋ณด ์œ ์ถœ ๋“ฑ์˜ ํ”ผํ•ด๊ฐ€ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ”ง Fix: canonicalFile ๋Œ€์‹  toPath().toAbsolutePath().normalize().toFile()๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์‹ฌ๋ณผ๋ฆญ ๋งํฌ๋ฅผ ํ•ด์„ํ•˜์ง€ ์•Š์€ ์ƒํƒœ์˜ ์ ˆ๋Œ€ ๊ฒฝ๋กœ๋ฅผ ๊ฐ€์ ธ์˜ค๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ์ด๋กœ์จ Files.isDirectory ํ•จ์ˆ˜๊ฐ€ ์‹ฌ๋ณผ๋ฆญ ๋งํฌ๋ฅผ ์ •์ƒ์ ์œผ๋กœ ์ฐจ๋‹จํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
โœ… Verification: testGoRejectsSymlinkTopDir ํ…Œ์ŠคํŠธ ์ผ€์ด์Šค๊ฐ€ ์„ฑ๊ณต์ ์œผ๋กœ ํ†ต๊ณผํ•˜๋ฉฐ 100% ์ฝ”๋“œ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ๊ฒ€์ฆํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 8396158036172354303 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Closing as superseded during org-wide PR triage. Keeping #108 as the canonical PR for the same overlapping topic: symlink/path traversal hardening. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded during org-wide PR triage. Keeping #108 as the canonical PR for the same overlapping topic: symlink/path traversal hardening. This PR is stale/conflicted or has review blockers, so retaining one current PR reduces duplicated review and merge conflict work.

Understood. Acknowledging that this work is superseded by #108 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant