π‘οΈ Sentinel: [CRITICAL] νμΌ νμ₯μ κ²μ¦ μ°ν μ·¨μ½μ μμ #99
π‘οΈ Sentinel: [CRITICAL] νμΌ νμ₯μ κ²μ¦ μ°ν μ·¨μ½μ μμ #99seonghobae wants to merge 1 commit into
Conversation
π¨ Severity: CRITICAL π‘ Vulnerability: νμΌ μ λ‘λ μ νμΌλͺ μ Null Byte(\u0000)λ₯Ό ν¬ν¨νμ¬ νμ₯μ κ²μ¦μ μ°νν μ μλ μ·¨μ½μ μ΄ μ‘΄μ¬νμ΅λλ€. π― Impact: μ°¨λ¨λ νμ₯μ(μ: .hwp, .hwpx)λ₯Ό κ°μ§ νμΌμ΄ νμ©λ νμ₯μ(μ: .pdf)λ‘ μμ₯λμ΄ μμ€ν μ μ λ‘λλκ³ μ²λ¦¬λ μ μμ΅λλ€. π§ Fix: `DefaultDocumentValidationService.java`μ `validateOrThrow` λ©μλ μ΄κΈ°μ νμΌλͺ μ Null Byteκ° ν¬ν¨λμ΄ μλμ§ νμΈνκ³ , λ°κ²¬λ κ²½μ° μ¦μ `IllegalArgumentException`μ λ°μμμΌ μ λ ₯μ κ±°λΆνλλ‘ μμ νμ΅λλ€. β Verification: Null Byteκ° ν¬ν¨λ νμΌλͺ μ ν μ€νΈνλ λ¨μ ν μ€νΈλ₯Ό `DefaultDocumentValidationServiceTest.java`μ μΆκ°νμ¬ κ²μ¦μ μλ£νμΌλ©°, `mvn test` λ° `mvn -DskipTests checkstyle:check`λ₯Ό λͺ¨λ ν΅κ³Όνμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
μ€λ³΅ μ 리: μ΄ PRμ 'νμΌ νμ₯μ/null-byte κ²μ¦' ν΄λ¬μ€ν°μ μ€λ³΅μ λλ€. μ λ³ΈμΌλ‘ #76 (APPROVED + CI green + MERGEABLE)μ μ μ§ν©λλ€. λμΌ νμΌμ μμ ν΄ λμ λ³ν©μ΄ λΆκ°λ₯νλ―λ‘ μ 리ν©λλ€. κ³ μ νκ² νμν λ³κ²½μ΄ μμΌλ©΄ #76μ λ°μνκ±°λ μ¬μ€ννμΈμ. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. I will close this PR as requested since it is a duplicate of #76. |
π¨ Severity: CRITICAL
π‘ Vulnerability: νμΌ μ λ‘λ μ νμΌλͺ μ Null Byte(\u0000)λ₯Ό ν¬ν¨νμ¬ νμ₯μ κ²μ¦μ μ°νν μ μλ μ·¨μ½μ μ΄ μ‘΄μ¬νμ΅λλ€.
π― Impact: μ°¨λ¨λ νμ₯μ(μ: .hwp, .hwpx)λ₯Ό κ°μ§ νμΌμ΄ νμ©λ νμ₯μ(μ: .pdf)λ‘ μμ₯λμ΄ μμ€ν μ μ λ‘λλκ³ μ²λ¦¬λ μ μμ΅λλ€.
π§ Fix:
DefaultDocumentValidationService.javaμvalidateOrThrowλ©μλ μ΄κΈ°μ νμΌλͺ μ Null Byteκ° ν¬ν¨λμ΄ μλμ§ νμΈνκ³ , λ°κ²¬λ κ²½μ° μ¦μIllegalArgumentExceptionμ λ°μμμΌ μ λ ₯μ κ±°λΆνλλ‘ μμ νμ΅λλ€.β Verification: Null Byteκ° ν¬ν¨λ νμΌλͺ μ ν μ€νΈνλ λ¨μ ν μ€νΈλ₯Ό
DefaultDocumentValidationServiceTest.javaμ μΆκ°νμ¬ κ²μ¦μ μλ£νμΌλ©°,mvn testλ°mvn -DskipTests checkstyle:checkλ₯Ό λͺ¨λ ν΅κ³Όνμ΅λλ€.PR created automatically by Jules for task 5916461807070755277 started by @seonghobae