Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] 파일 ν™•μž₯자 검증 우회 취약점 μˆ˜μ •#99

Closed
seonghobae wants to merge 1 commit into
mainfrom
sentinel/fix-null-byte-vulnerability-5916461807070755277
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] 파일 ν™•μž₯자 검증 우회 취약점 μˆ˜μ •#99
seonghobae wants to merge 1 commit into
mainfrom
sentinel/fix-null-byte-vulnerability-5916461807070755277

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: 파일 μ—…λ‘œλ“œ μ‹œ 파일λͺ…에 Null Byte(\u0000)λ₯Ό ν¬ν•¨ν•˜μ—¬ ν™•μž₯자 검증을 μš°νšŒν•  수 μžˆλŠ” 취약점이 μ‘΄μž¬ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: μ°¨λ‹¨λœ ν™•μž₯자(예: .hwp, .hwpx)λ₯Ό κ°€μ§„ 파일이 ν—ˆμš©λœ ν™•μž₯자(예: .pdf)둜 μœ„μž₯λ˜μ–΄ μ‹œμŠ€ν…œμ— μ—…λ‘œλ“œλ˜κ³  처리될 수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: DefaultDocumentValidationService.java의 validateOrThrow λ©”μ„œλ“œ μ΄ˆκΈ°μ— 파일λͺ…에 Null Byteκ°€ ν¬ν•¨λ˜μ–΄ μžˆλŠ”μ§€ ν™•μΈν•˜κ³ , 발견될 경우 μ¦‰μ‹œ IllegalArgumentException을 λ°œμƒμ‹œμΌœ μž…λ ₯을 κ±°λΆ€ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
βœ… Verification: Null Byteκ°€ ν¬ν•¨λœ 파일λͺ…을 ν…ŒμŠ€νŠΈν•˜λŠ” λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό DefaultDocumentValidationServiceTest.java에 μΆ”κ°€ν•˜μ—¬ 검증을 μ™„λ£Œν–ˆμœΌλ©°, mvn test 및 mvn -DskipTests checkstyle:checkλ₯Ό λͺ¨λ‘ ν†΅κ³Όν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 5916461807070755277 started by @seonghobae

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: 파일 μ—…λ‘œλ“œ μ‹œ 파일λͺ…에 Null Byte(\u0000)λ₯Ό ν¬ν•¨ν•˜μ—¬ ν™•μž₯자 검증을 μš°νšŒν•  수 μžˆλŠ” 취약점이 μ‘΄μž¬ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Impact: μ°¨λ‹¨λœ ν™•μž₯자(예: .hwp, .hwpx)λ₯Ό κ°€μ§„ 파일이 ν—ˆμš©λœ ν™•μž₯자(예: .pdf)둜 μœ„μž₯λ˜μ–΄ μ‹œμŠ€ν…œμ— μ—…λ‘œλ“œλ˜κ³  처리될 수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ Fix: `DefaultDocumentValidationService.java`의 `validateOrThrow` λ©”μ„œλ“œ μ΄ˆκΈ°μ— 파일λͺ…에 Null Byteκ°€ ν¬ν•¨λ˜μ–΄ μžˆλŠ”μ§€ ν™•μΈν•˜κ³ , 발견될 경우 μ¦‰μ‹œ `IllegalArgumentException`을 λ°œμƒμ‹œμΌœ μž…λ ₯을 κ±°λΆ€ν•˜λ„λ‘ μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.
βœ… Verification: Null Byteκ°€ ν¬ν•¨λœ 파일λͺ…을 ν…ŒμŠ€νŠΈν•˜λŠ” λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό `DefaultDocumentValidationServiceTest.java`에 μΆ”κ°€ν•˜μ—¬ 검증을 μ™„λ£Œν–ˆμœΌλ©°, `mvn test` 및 `mvn -DskipTests checkstyle:check`λ₯Ό λͺ¨λ‘ ν†΅κ³Όν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

쀑볡 정리: 이 PR은 '파일 ν™•μž₯자/null-byte 검증' ν΄λŸ¬μŠ€ν„°μ˜ μ€‘λ³΅μž…λ‹ˆλ‹€. μ •λ³ΈμœΌλ‘œ #76 (APPROVED + CI green + MERGEABLE)을 μœ μ§€ν•©λ‹ˆλ‹€. 동일 νŒŒμΌμ„ μˆ˜μ •ν•΄ λ™μ‹œ 병합이 λΆˆκ°€λŠ₯ν•˜λ―€λ‘œ μ •λ¦¬ν•©λ‹ˆλ‹€. κ³ μœ ν•˜κ²Œ ν•„μš”ν•œ 변경이 있으면 #76에 λ°˜μ˜ν•˜κ±°λ‚˜ μž¬μ˜€ν”ˆν•˜μ„Έμš”.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

쀑볡 정리: 이 PR은 '파일 ν™•μž₯자/null-byte 검증' ν΄λŸ¬μŠ€ν„°μ˜ μ€‘λ³΅μž…λ‹ˆλ‹€. μ •λ³ΈμœΌλ‘œ #76 (APPROVED + CI green + MERGEABLE)을 μœ μ§€ν•©λ‹ˆλ‹€. 동일 νŒŒμΌμ„ μˆ˜μ •ν•΄ λ™μ‹œ 병합이 λΆˆκ°€λŠ₯ν•˜λ―€λ‘œ μ •λ¦¬ν•©λ‹ˆλ‹€. κ³ μœ ν•˜κ²Œ ν•„μš”ν•œ 변경이 있으면 #76에 λ°˜μ˜ν•˜κ±°λ‚˜ μž¬μ˜€ν”ˆν•˜μ„Έμš”.

Understood. Acknowledging that this work is now obsolete and stopping work on this task. I will close this PR as requested since it is a duplicate of #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant