Skip to content

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— λ‘œλ”© μŠ€ν”Όλ„ˆ μΆ”κ°€#71

Open
seonghobae wants to merge 2 commits into
mainfrom
palette/ux-loading-spinner-13872914459436426456
Open

🎨 Palette: 비동기 μž‘μ—… λ²„νŠΌμ— λ‘œλ”© μŠ€ν”Όλ„ˆ μΆ”κ°€#71
seonghobae wants to merge 2 commits into
mainfrom
palette/ux-loading-spinner-13872914459436426456

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What: 비동기 μž‘μ—… λ²„νŠΌ(μƒˆλ‘œκ³ μΉ¨)에 λͺ…μ‹œμ μΈ μ‹œκ°μ  λ‘œλ”© μŠ€ν”Όλ„ˆλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: κΈ°μ‘΄μ—λŠ” ν…μŠ€νŠΈλ§Œ "Refreshing..."으둜 λ³€κ²½λ˜μ—ˆλŠ”λ°, μ‚¬μš©μžκ°€ ν…μŠ€νŠΈ 변경을 μ¦‰μ‹œ μΈμ§€ν•˜μ§€ λͺ»ν•˜λŠ” κ²½μš°κ°€ λ§ŽμŠ΅λ‹ˆλ‹€. μ• λ‹ˆλ©”μ΄μ…˜μ΄ ν¬ν•¨λœ μŠ€ν”Όλ„ˆλ₯Ό μΆ”κ°€ν•˜λ©΄ μž‘μ—…μ΄ μ§„ν–‰ μ€‘μž„μ„ λͺ…ν™•ν•˜κ³  μ¦‰κ°μ μœΌλ‘œ μ•Œλ¦΄ 수 μžˆμ–΄ λΆˆμ•ˆκ°μ„ 쀄이고 UXλ₯Ό κ°œμ„ ν•  수 μžˆμŠ΅λ‹ˆλ‹€.
β™Ώ Accessibility: aria-hidden="true"λ₯Ό μŠ€ν”Όλ„ˆ μš”μ†Œμ— μ μš©ν•˜μ—¬ 슀크린 λ¦¬λ”μ—μ„œ μ€‘λ³΅μœΌλ‘œ μ½νžˆμ§€ μ•Šκ²Œ ν•˜μ˜€κ³ , CSS prefers-reduced-motion 섀정을 μ‘΄μ€‘ν•˜μ—¬ μ• λ‹ˆλ©”μ΄μ…˜μ„ λΉ„ν™œμ„±ν™”ν•  수 μžˆλ„λ‘ μ²˜λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 13872914459436426456 started by @seonghobae

- `viewer.css`에 접근성을 κ³ λ €ν•œ(reduced-motion) μŠ€ν”Όλ„ˆ μŠ€νƒ€μΌ(`.spinner`, `@keyframes spin`) μΆ”κ°€
- `viewer.js`μ—μ„œ 비동기 데이터λ₯Ό κ°€μ Έμ˜¬ λ•Œ λ²„νŠΌμ— ν…μŠ€νŠΈλ§Œ λ³€κ²½ν•˜λ˜ 것을 μŠ€ν”Όλ„ˆ μ•„μ΄μ½˜κ³Ό ν•¨κ»˜ ν‘œμ‹œν•˜λ„λ‘ κ°œμ„ 
- UX μΈμ‚¬μ΄νŠΈλ₯Ό `.jules/palette.md`에 기둝
Copilot AI review requested due to automatic review settings July 1, 2026 21:31
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a visual loading spinner to the viewer’s async β€œRefresh” button to make in-progress states more immediately recognizable, while honoring prefers-reduced-motion and avoiding redundant screen reader output.

Changes:

  • Update the viewer refresh button’s loading state to include a decorative spinner (aria-hidden="true") alongside the β€œRefreshing...” text.
  • Add spinner animation styling and disable it under prefers-reduced-motion: reduce.
  • Document the pattern in .jules/palette.md for future UI consistency.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main/resources/static/assets/viewer/viewer.js Updates the refresh button loading-state rendering to include a spinner.
src/main/resources/static/assets/viewer/viewer.css Introduces .spinner styling/animation and reduces motion when requested.
.jules/palette.md Records the UX/accessibility guidance for async refresh loading indicators.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main/resources/static/assets/viewer/viewer.js Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head evidence but found unresolved reviewer or review-agent threads before approval.

Findings

1. HIGH .github/workflows/opencode-review.yml:1 - Unresolved reviewer thread blocks automated approval

  • Problem: OpenCode reached an APPROVE control result, but the approval step found unresolved, non-outdated human or review-agent thread evidence on the current pull request.
  • Root cause: Reviewer and review-agent feedback can arrive after bounded model evidence is prepared, so the approval step must re-query GitHub immediately before publishing an approval.
  • Fix: Address or resolve the listed reviewer thread(s), then re-run OpenCode on the current head.
  • Regression test: Keep the approval gate querying reviewThreads(first: 100) after model output and before create_pull_review APPROVE, including bot review agents other than OpenCode itself.

Review thread evidence

Latest unresolved reviewer thread evidence

src/main/resources/static/assets/viewer/viewer.js line 49

  • Latest reviewer comment: @copilot-pull-request-reviewer at 2026-07-01T21:33:10Z

  • Comment URL: #71 (comment)

  • Comment excerpt: Avoid using innerHTML for UI state updates when plain DOM APIs are sufficient. Even though this string is currently constant, innerHTML makes it easier for future changes to accidentally introduce DOM injection/XSS (e.g., if interpolating a server-provided message). Build the spinner element via createElement/replaceChildren instead.

  • Result: REQUEST_CHANGES

  • Reason: unresolved reviewer or review-agent thread(s) were present before approval.

  • Head SHA: 89d7244cbc2b7c592b541ce9b6d325bf9f91f0d8

  • Workflow run: 28549097768

  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown

OpenCode Review Overview

  • Head SHA: a855cf72aa58afc51c73cc5471862023958982d9
  • Workflow run: 28623301780
  • Workflow attempt: 1
  • Gate result: APPROVE (approval step)

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/palette.md, src/main/resources/static/assets/viewer/viewer.css, src/main/resources/static/assets/viewer/viewer.js.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects .jules/palette.md to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: The PR adds a loading spinner for async actions, improving UX with visual feedback. Changes are well-documented and tested.
  • Head SHA: a855cf72aa58afc51c73cc5471862023958982d9
  • Workflow run: 28623301780
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

@seonghobae seonghobae dismissed github-actions[bot]’s stale review July 2, 2026 12:03

리뷰 μž¬κΈ°λ™

- CI κ²€μ‚¬μ—μ„œ 보고된 잠재적 XSS 취약점을 ν•΄κ²°ν•˜κΈ° μœ„ν•΄ `viewer.js`의 `innerHTML` μ‚¬μš©μ„ 제거
- `document.createElement()`와 `replaceChildren()`을 μ‚¬μš©ν•˜μ—¬ λ‘œλ”© μŠ€ν”Όλ„ˆμ™€ ν…μŠ€νŠΈλ₯Ό DOM에 μ•ˆμ „ν•˜κ²Œ μ‚½μž…ν•˜λ„λ‘ κ°œμ„ 

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode reviewed the current-head bounded evidence and found no blocking issues.

Findings

No blocking findings.

Summary

Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including .jules/palette.md, src/main/resources/static/assets/viewer/viewer.css, src/main/resources/static/assets/viewer/viewer.js.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports test coverage as not applicable because no supported changed source files or package manifests were found.
Docstring coverage: coverage execution evidence reports docstring coverage as not applicable because no supported changed source files or package manifests were found.
DAG: CodeGraph/source-backed behavior map connects .jules/palette.md to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.

  • Result: APPROVE
  • Reason: The PR adds a loading spinner for async actions, improving UX with visual feedback. Changes are well-documented and tested.
  • Head SHA: a855cf72aa58afc51c73cc5471862023958982d9
  • Workflow run: 28623301780
  • Workflow attempt: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]
Loading

@github-actions github-actions Bot enabled auto-merge (squash) July 3, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants