π‘οΈ Sentinel: [HIGH] λ λ°μ΄νΈ μ½μ μ·¨μ½μ μμ #42
π‘οΈ Sentinel: [HIGH] λ λ°μ΄νΈ μ½μ
μ·¨μ½μ μμ #42seonghobae wants to merge 4 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
μ€λ³΅ μ 리: μ΄ PRμ 'νμΌ νμ₯μ/null-byte κ²μ¦' ν΄λ¬μ€ν°μ μ€λ³΅μ λλ€. μ λ³ΈμΌλ‘ #76 (APPROVED + CI green + MERGEABLE)μ μ μ§ν©λλ€. λμΌ νμΌμ μμ ν΄ λμ λ³ν©μ΄ λΆκ°λ₯νλ―λ‘ μ 리ν©λλ€. κ³ μ νκ² νμν λ³κ²½μ΄ μμΌλ©΄ #76μ λ°μνκ±°λ μ¬μ€ννμΈμ. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. I will close this PR and defer to the canonical PR #76. |
π¨ Severity: HIGH
π‘ Vulnerability: νμΌ μ΄λ¦μ λ λ°μ΄νΈ(
\0)κ° ν¬ν¨λ κ²½μ°, Javaμμλ 무μνκ³ νμ₯μλ₯Ό μ¬λ°λ₯΄κ² μΆμΆνλ κ²μ²λΌ λ³΄μΌ μ μμ§λ§, νμ C/C++ κΈ°λ°μ λΌμ΄λΈλ¬λ¦¬λ μμ€ν μμ νμΌ μ²λ¦¬ μ λ¬Έμμ΄μ΄ λ λ°μ΄νΈμμ λ겨 μλͺ»λ νμ₯μλ‘ νμΌμ μ²λ¦¬ν μ μλ μ·¨μ½μ μ΄ μμ΅λλ€.π― Impact: 곡격μκ° μ°¨λ¨λ νμΌ νμ(
.hwp)μ μ μμ μΈ λ λ°μ΄νΈ μ½μ (malicious.hwp\0.pdf)μ ν΅ν΄ μ λ‘λνμ¬ μλ² λ΄ μμ€ν μ 곡격ν μ μμ΅λλ€.π§ Fix:
DefaultDocumentValidationService.javaλ΄μμ νμ₯μλ₯Ό μΆμΆνκΈ° μ νμΌ μ΄λ¦μ λ λ°μ΄νΈ(\0)κ° ν¬ν¨λμ΄ μλμ§ νμΈνκ³ ν¬ν¨λμ΄ μμΌλ©΄ μμΈ μ²λ¦¬λ₯Ό νλλ‘ λ³κ²½νμ΅λλ€. ν μ€νΈ νμΌDefaultDocumentValidationServiceTest.javaμ ν΄λΉ μ·¨μ½μ μ λ°©μ΄νλ ν μ€νΈ(rejectsFilenameWithNullByte)λ₯Ό μΆκ°νμ΅λλ€.β Verification:
mvn testλͺ λ Ήμ΄λ‘ ν μ€νΈκ° 100% ν΅κ³Όν¨μ νμΈνμ΅λλ€.PR created automatically by Jules for task 4383671025421526163 started by @seonghobae