Skip to content

🎨 Palette: Add explicit loading & disabled states to async buttons (demo.js, viewer.js)#100

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-ux-async-button-loading-states-3083793743190559699
Closed

🎨 Palette: Add explicit loading & disabled states to async buttons (demo.js, viewer.js)#100
seonghobae wants to merge 1 commit into
mainfrom
palette-ux-async-button-loading-states-3083793743190559699

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

🎨 Palette: 비동기 λ²„νŠΌ λ‘œλ”© 및 λΉ„ν™œμ„±ν™” μƒνƒœ μΆ”κ°€

πŸ’‘ What

  • 비동기 처리(λ„€νŠΈμ›Œν¬ μš”μ²­ λ“±)λ₯Ό μˆ˜ν–‰ν•˜λŠ” λ²„νŠΌ(Submit document, Refresh evidence, Retry dead-lettered job λ“±)에 λͺ…μ‹œμ μΈ λ‘œλ”© μƒνƒœλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
  • μž‘μ—…μ΄ μ§„ν–‰ 쀑일 λ•Œ λ²„νŠΌμ΄ λΉ„ν™œμ„±ν™”(disabled=true) λ˜λ„λ‘ ν•˜κ³ , λ²„νŠΌ ν…μŠ€νŠΈλ₯Ό "Loading...", "Submitting..." λ“±μœΌλ‘œ 동적 λ³€κ²½ν–ˆμŠ΅λ‹ˆλ‹€.
  • μ›λž˜μ˜ λ²„νŠΌ ν…μŠ€νŠΈλ₯Ό μ•ˆμ „ν•˜κ²Œ μ €μž₯ν•œ 뒀에, μ—λŸ¬ μœ λ¬΄μ™€ 관계없이 finally λΈ”λ‘μ—μ„œ λ³΅μ›ν•˜λ„λ‘ μ²˜λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

  • μž‘μ—… μ™„λ£Œ μ „ λ²„νŠΌμ„ μ—¬λŸ¬ 번 λˆ„λ₯΄λŠ” 경우λ₯Ό λ°©μ§€ν•©λ‹ˆλ‹€.
  • μ‚¬μš©μžμ—κ²Œ μ‹œμŠ€ν…œμ΄ μš”μ²­μ„ 처리 μ€‘μž„μ„ μ‹œκ°μ μœΌλ‘œ λͺ…ν™•ν•˜κ²Œ μ•Œλ €μ£Όμ–΄ ν˜Όλž€μ„ 쀄이고 신뒰감을 λ†’μž…λ‹ˆλ‹€ (UX ν–₯상).

πŸ“Έ Before/After

  • Playwright 검증을 톡해 Submitting..., Refreshing... λ“±μ˜ 동적 λ³€ν™”λ₯Ό μ‹œκ°μ μœΌλ‘œ ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€. (ν•΄λ‹Ή μŠ€ν¬λ¦°μƒ· 캑쳐 μ™„λ£Œ)

β™Ώ Accessibility

  • μž‘μ—… μ§„ν–‰ μ€‘μ—λŠ” μŠ€ν¬λ¦°λ¦¬λ” λ“± 보쑰 기기에 μƒνƒœ λ³€ν™”λ₯Ό μ•Œλ¦¬κΈ° μœ„ν•΄ λ™μ μœΌλ‘œ aria-busy="true" 속성을 λΆ€μ—¬ν•˜κ³  μž‘μ—… ν›„ μ œκ±°ν•˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

PR created automatically by Jules for task 3083793743190559699 started by @seonghobae

- `demo.js`: `createActionButton`, `retryActiveJob`, `refreshKpiEvidence`, `submitDocument`μ—μ„œ λ„€νŠΈμ›Œν¬ μš”μ²­ μ§„ν–‰ μ‹œ λ²„νŠΌμ„ λΉ„ν™œμ„±ν™”ν•˜κ³  λ‘œλ”© ν…μŠ€νŠΈ ν‘œκΈ°, `aria-busy` 속성 μΆ”κ°€.
- μ›λž˜μ˜ λ²„νŠΌ ν…μŠ€νŠΈλ₯Ό λ³€μˆ˜μ— μ €μž₯ν•˜μ—¬ λ™μ μœΌλ‘œ λ³΅μ›ν•˜λ„λ‘ 처리.
- `viewer.js`: `retryBtn`에 λŒ€ν•΄ μΌκ΄€λ˜κ²Œ `aria-busy` 속성을 μ—…λ°μ΄νŠΈν•˜λ„λ‘ μƒνƒœ 반영.
- 비동기 μž‘μ—…μ— λŒ€ν•œ λͺ…μ‹œμ μΈ μƒνƒœλ₯Ό μ‚¬μš©μžμ—κ²Œ μ œκ³΅ν•¨μœΌλ‘œμ¨ ν˜Όλž€μ„ λ°©μ§€ν•˜κ³  이쀑 클릭 λ“±μ˜ 였λ₯˜ 예방 (μ ‘κ·Όμ„± ν–₯상 포함).
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

쀑볡 정리: 이 PR은 'async λ²„νŠΌ λ‘œλ”© μƒνƒœ' ν΄λŸ¬μŠ€ν„°μ˜ μ€‘λ³΅μž…λ‹ˆλ‹€. μ •λ³ΈμœΌλ‘œ #71 (APPROVED + CI green + MERGEABLE)을 μœ μ§€ν•©λ‹ˆλ‹€. 동일 νŒŒμΌμ„ μˆ˜μ •ν•΄ λ™μ‹œ 병합이 λΆˆκ°€λŠ₯ν•˜λ―€λ‘œ μ •λ¦¬ν•©λ‹ˆλ‹€. κ³ μœ ν•˜κ²Œ ν•„μš”ν•œ 변경이 있으면 #71에 λ°˜μ˜ν•˜κ±°λ‚˜ μž¬μ˜€ν”ˆν•˜μ„Έμš”.

@seonghobae seonghobae closed this Jul 7, 2026
@google-labs-jules

Copy link
Copy Markdown

쀑볡 정리: 이 PR은 'async λ²„νŠΌ λ‘œλ”© μƒνƒœ' ν΄λŸ¬μŠ€ν„°μ˜ μ€‘λ³΅μž…λ‹ˆλ‹€. μ •λ³ΈμœΌλ‘œ #71 (APPROVED + CI green + MERGEABLE)을 μœ μ§€ν•©λ‹ˆλ‹€. 동일 νŒŒμΌμ„ μˆ˜μ •ν•΄ λ™μ‹œ 병합이 λΆˆκ°€λŠ₯ν•˜λ―€λ‘œ μ •λ¦¬ν•©λ‹ˆλ‹€. κ³ μœ ν•˜κ²Œ ν•„μš”ν•œ 변경이 있으면 #71에 λ°˜μ˜ν•˜κ±°λ‚˜ μž¬μ˜€ν”ˆν•˜μ„Έμš”.

μ•Œκ² μŠ΅λ‹ˆλ‹€. 이 μž‘μ—…μ΄ 이미 λ¨Έμ§€λœ μ •λ³Έκ³Ό μ€‘λ³΅λ˜μ–΄ μ“Έλͺ¨μ—†κ²Œ 된 점을 μΈμ§€ν•˜μ˜€μœΌλ©°, 이 PR의 μž‘μ—…μ„ μ€‘μ§€ν•˜κ² μŠ΅λ‹ˆλ‹€.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant