π¨ Palette: Add explicit loading & disabled states to async buttons (demo.js, viewer.js)#100
Conversation
- `demo.js`: `createActionButton`, `retryActiveJob`, `refreshKpiEvidence`, `submitDocument`μμ λ€νΈμν¬ μμ² μ§ν μ λ²νΌμ λΉνμ±ννκ³ λ‘λ© ν μ€νΈ νκΈ°, `aria-busy` μμ± μΆκ°. - μλμ λ²νΌ ν μ€νΈλ₯Ό λ³μμ μ μ₯νμ¬ λμ μΌλ‘ 볡μνλλ‘ μ²λ¦¬. - `viewer.js`: `retryBtn`μ λν΄ μΌκ΄λκ² `aria-busy` μμ±μ μ λ°μ΄νΈνλλ‘ μν λ°μ. - λΉλκΈ° μμ μ λν λͺ μμ μΈ μνλ₯Ό μ¬μ©μμκ² μ 곡ν¨μΌλ‘μ¨ νΌλμ λ°©μ§νκ³ μ΄μ€ ν΄λ¦ λ±μ μ€λ₯ μλ°© (μ κ·Όμ± ν₯μ ν¬ν¨).
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
μ€λ³΅ μ 리: μ΄ PRμ 'async λ²νΌ λ‘λ© μν' ν΄λ¬μ€ν°μ μ€λ³΅μ λλ€. μ λ³ΈμΌλ‘ #71 (APPROVED + CI green + MERGEABLE)μ μ μ§ν©λλ€. λμΌ νμΌμ μμ ν΄ λμ λ³ν©μ΄ λΆκ°λ₯νλ―λ‘ μ 리ν©λλ€. κ³ μ νκ² νμν λ³κ²½μ΄ μμΌλ©΄ #71μ λ°μνκ±°λ μ¬μ€ννμΈμ. |
μκ² μ΅λλ€. μ΄ μμ μ΄ μ΄λ―Έ λ¨Έμ§λ μ λ³Έκ³Ό μ€λ³΅λμ΄ μΈλͺ¨μκ² λ μ μ μΈμ§νμμΌλ©°, μ΄ PRμ μμ μ μ€μ§νκ² μ΅λλ€. |
π¨ Palette: λΉλκΈ° λ²νΌ λ‘λ© λ° λΉνμ±ν μν μΆκ°
π‘ What
Submit document,Refresh evidence,Retry dead-lettered jobλ±)μ λͺ μμ μΈ λ‘λ© μνλ₯Ό μΆκ°νμ΅λλ€.disabled=true) λλλ‘ νκ³ , λ²νΌ ν μ€νΈλ₯Ό "Loading...", "Submitting..." λ±μΌλ‘ λμ λ³κ²½νμ΅λλ€.finallyλΈλ‘μμ 볡μνλλ‘ μ²λ¦¬νμ΅λλ€.π― Why
πΈ Before/After
Submitting...,Refreshing...λ±μ λμ λ³νλ₯Ό μκ°μ μΌλ‘ νμΈνμ΅λλ€. (ν΄λΉ μ€ν¬λ¦°μ· μΊ‘μ³ μλ£)βΏ Accessibility
aria-busy="true"μμ±μ λΆμ¬νκ³ μμ ν μ κ±°νλλ‘ κ°μ νμ΅λλ€.PR created automatically by Jules for task 3083793743190559699 started by @seonghobae