π‘οΈ Sentinel: [HIGH] Analysis API κ²½λ‘ μ‘°μ(Path Traversal) μ·¨μ½μ μμ #578
π‘οΈ Sentinel: [HIGH] Analysis API κ²½λ‘ μ‘°μ(Path Traversal) μ·¨μ½μ μμ #578seonghobae wants to merge 2 commits into
Conversation
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: API payload νλμΈ
cacheRootμtempRootμ λν κ²½λ‘ μ‘°μ(Path Traversal) κ²μ¦μ΄ λλ½λμ΄ μμμ λλ ν 리 μ κ·Όμ΄ κ°λ₯ν μ·¨μ½μ μ΄ μ‘΄μ¬νμ΅λλ€.π― Impact: μ μμ μΈ νμ΄λ‘λλ₯Ό ν΅ν΄ μμ€ν μ λ€λ₯Έ λλ ν 리μ μ κ·Όνκ±°λ νμΌμ μ½κ³ μΈ μ μλ μ μ¬μ μΈ λ³΄μ μνμ΄ μμμ΅λλ€.
π§ Fix:
validate_analysis_job_requestν¨μμcacheRootμtempRootκ°μ΄ μ λ¬λ λ,..λ¬Έμμ΄μ ν¬ν¨νλμ§ λ€μ€ νλ«νΌ νΈν λ°©μμΌλ‘ κ²μ¬(path.replace('\\', '/').split('/'))νμ¬ λλ ν 리 μ‘°μ μλλ₯Ό μ°¨λ¨νμ΅λλ€. μ¬μ©μ μ§μ μ€λμ€ κ²½λ‘μμλ μ μμ μΈ~(expanduser) κ²½λ‘ ν΄μμ μ μ§νλ©΄μ μ±μ΄ κ΄λ¦¬νλ κ²½λ‘ μ λ ₯λ§ μ격ν κ²μ¦νλλ‘ μμ νμ΅λλ€.β Verification: μ λμ€(Unix) λ° μλμ°(Windows) μ€νμΌμ κ²½λ‘ μ‘°μ νμ΄λ‘λλ₯Ό νμ§νκ³ κ±°λΆνλ ν μ€νΈ μΌμ΄μ€λ₯Ό
test_api.pyμ μΆκ°νμ¬ κ²μ¦μ μλ£νμ΅λλ€.PR created automatically by Jules for task 7581725107369249139 started by @seonghobae