feat(roles): sustained vs choppy articulation detection#573
Open
seonghobae wants to merge 1 commit into
Open
Conversation
The rehearsal domain model requires groove guidance including 'sustained versus choppy roles'. Per stem: onset density over active audio (librosa onset_detect + RMS activity gating) and duty cycle -> character 'sustained' (duty>0.6, <1.5 onsets/s), 'choppy' (>=3/s or duty<0.35), else 'mixed'. Safe failure on silent/empty stems. 100% coverage; full suite 443 passed. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjGVapDZ3k7V7zKYk16P4C
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sustained-vs-choppy articulation detection per stem: onset density over ACTIVE audio (onset_detect + RMS activity gating) and duty cycle →
character"sustained" / "choppy" / "mixed" with documented thresholds, plus the raw metrics.Why
Domain-model groove guidance requires "sustained versus choppy roles" — whether a part holds long notes or plays punctuated figures. Nothing implemented it.
Tests
Deterministic synthetic stems: continuous sine → "sustained"; 4/s staccato bursts → "choppy"; 1s-notes-with-gaps → "mixed" band; silent/empty → safe default. 100% coverage on the module; full suite 443 passed; ruff/format/mypy clean.
🤖 Generated with Claude Code