fix: guard project IDs before path joins#527
Open
seonghobae wants to merge 7 commits into
Open
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_root.join(project_id)path construction../..path components,/, and\, while preserving benign identifiers such asmy..id.projectIddirectly reachesapp_owned_root.Verification
cargo fmt --manifest-path apps/desktop/src-tauri/Cargo.toml --checknpm ci(local Node v24.16.0 emits repo engine warning; install succeeds)npm --workspace apps/desktop run buildcargo test --manifest-path apps/desktop/src-tauri/Cargo.toml project_id -- --nocapturepython3 scripts/checks/verify_security_notes.pypython3 scripts/checks/verify_supply_chain.pypython3 scripts/checks/security_gates.pygit diff --checkSupersedes the security intent of #494, whose branch currently contains broad unrelated workflow/design/package churn and remains merge-dirty.