π¨ Palette: [UX improvement] λμ보λ ν μ΄λΈ ν€λ³΄λ μ κ·Όμ± λ° νΌ λ μ΄λΈ κ°μ #260
Conversation
β¦ labels - Added `aria-label` to file input, search input, and severity select. - Made table rows focusable with `tabindex="0"`. - Added `keydown` event listener to table rows to trigger detail modal on 'Enter' and 'Space'. - Added `:focus-visible` styling to table rows for clear visual feedback during keyboard navigation. - Updated .jules/palette.md with the learnings.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
β¦402370554056705
π‘ 무μμ λ³κ²½νλμ? (What):
λμ보λμ μ κ·Όμ± ν₯μμ μν΄ λ€μκ³Ό κ°μ λ³κ²½ μ¬νμ μΆκ°νμ΅λλ€.
index.htmlλ΄ νμΌ μ λ‘λ, κ²μμ°½, μ¬κ°λ μ ν λλ‘λ€μ΄μaria-labelμμ± μΆκ°.<tr>)μtabindex="0"μ μΆκ°νμ¬ ν€λ³΄λ ν¬μ»€μ€ κ°λ₯νκ² μ€μ .keydownμ΄λ²€νΈ 리μ€λλ₯Ό μΆκ°νμ¬ ν€λ³΄λ(Enter, Space) μ‘°μμΌλ‘ μμΈ λͺ¨λ¬μ μ΄ μ μλλ‘ κΈ°λ₯ ꡬν.:focus-visibleCSS ν΄λμ€λ₯Ό μΆκ°νμ¬ ν€λ³΄λ λ΄λΉκ²μ΄μ μ μ΄λ€ νμ΄ ν¬μ»€μ€ λμ΄ μλμ§ λͺ ννκ² μκ°μ (outline)μΌλ‘ 보μ¬μ£Όλλ‘ μ€νμΌ κ°μ .π― μ λ³κ²½νλμ? (Why):
πΈ Before/After:
Enterν€λ‘ μμΈ λ΄μ©μ νμΈν μ μμ.Tabν€λ‘ ν μ΄λΈ νμΌλ‘ μ΄λμ΄ κ°λ₯νκ³ νλμ μ€κ³½μ μ΄ λνλλ©°,EnterλλSpaceν€λ‘ μμΈ λͺ¨λ¬ μ°½μ λμΈ μ μμ.βΏ μ κ·Όμ± (Accessibility):
aria-label):focus-visibleμ ν΅ν ν€λ³΄λ ν¬μ»€μ€ μΈμ§μ± κ°νPR created automatically by Jules for task 17265402370554056705 started by @seonghobae