Skip to content

🎨 Palette: [UX improvement] λŒ€μ‹œλ³΄λ“œ ν…Œμ΄λΈ” ν‚€λ³΄λ“œ μ ‘κ·Όμ„± 및 폼 λ ˆμ΄λΈ” κ°œμ„ #260

Open
seonghobae wants to merge 2 commits into
developfrom
palette/a11y-keyboard-nav-dashboard-17265402370554056705
Open

🎨 Palette: [UX improvement] λŒ€μ‹œλ³΄λ“œ ν…Œμ΄λΈ” ν‚€λ³΄λ“œ μ ‘κ·Όμ„± 및 폼 λ ˆμ΄λΈ” κ°œμ„ #260
seonghobae wants to merge 2 commits into
developfrom
palette/a11y-keyboard-nav-dashboard-17265402370554056705

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

πŸ’‘ 무엇을 λ³€κ²½ν–ˆλ‚˜μš”? (What):
λŒ€μ‹œλ³΄λ“œμ˜ μ ‘κ·Όμ„± ν–₯상을 μœ„ν•΄ λ‹€μŒκ³Ό 같은 λ³€κ²½ 사항을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

  1. index.html λ‚΄ 파일 μ—…λ‘œλ“œ, 검색창, 심각도 선택 λ“œλ‘­λ‹€μš΄μ— aria-label 속성 μΆ”κ°€.
  2. μƒν˜Έμž‘μš© κ°€λŠ₯ν•œ ν…Œμ΄λΈ”μ˜ ν–‰(<tr>)에 tabindex="0"을 μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ 포컀슀 κ°€λŠ₯ν•˜κ²Œ μ„€μ •.
  3. ν…Œμ΄λΈ” 행에 keydown 이벀트 λ¦¬μŠ€λ„ˆλ₯Ό μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ(Enter, Space) μ‘°μž‘μœΌλ‘œ 상세 λͺ¨λ‹¬μ„ μ—΄ 수 μžˆλ„λ‘ κΈ°λŠ₯ κ΅¬ν˜„.
  4. :focus-visible CSS 클래슀λ₯Ό μΆ”κ°€ν•˜μ—¬ ν‚€λ³΄λ“œ λ‚΄λΉ„κ²Œμ΄μ…˜ μ‹œ μ–΄λ–€ 행이 포컀슀 λ˜μ–΄ μžˆλŠ”μ§€ λͺ…ν™•ν•˜κ²Œ μ‹œκ°μ (outline)으둜 보여주도둝 μŠ€νƒ€μΌ κ°œμ„ .

🎯 μ™œ λ³€κ²½ν–ˆλ‚˜μš”? (Why):

  • μ‹œκ°μž₯μ• μΈμ΄λ‚˜ 슀크린 리더 μ‚¬μš©μžκ°€ 폼 컨트둀이 무엇인지 λͺ…ν™•νžˆ μ΄ν•΄ν•˜κ³  μ‘°μž‘ν•  수 있게 ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.
  • 마우슀 μ‚¬μš©μ΄ λΆˆνŽΈν•˜κ±°λ‚˜ ν‚€λ³΄λ“œ μ€‘μ‹¬μœΌλ‘œ λΈŒλΌμš°μ§• ν•˜λŠ” μ‚¬μš©μžλ“€μ΄ 클릭 μ΄λ²€νŠΈκ°€ κ±Έλ €μžˆλŠ” ν…Œμ΄λΈ” 행에 μ ‘κ·Όμ‘°μ°¨ ν•˜μ§€ λͺ»ν•˜λ˜ 문제λ₯Ό ν•΄κ²°ν–ˆμŠ΅λ‹ˆλ‹€.
  • ν¬μ»€μŠ€κ°€ λ˜μ—ˆμ„ λ•Œ λͺ…ν™•ν•œ μ‹œκ°μ  ν”Όλ“œλ°±μ„ μ œκ³΅ν•˜μ—¬ μ‚¬μš©μ„±μ„ ν–₯μƒμ‹œν‚΅λ‹ˆλ‹€.

πŸ“Έ Before/After:

  • Before: ν‚€λ³΄λ“œλ‘œ ν…Œμ΄λΈ” 행을 ν¬μ»€μŠ€ν•  수 μ—†κ³ , Enter ν‚€λ‘œ 상세 λ‚΄μš©μ„ 확인할 수 μ—†μŒ.
  • After: Tab ν‚€λ‘œ ν…Œμ΄λΈ” ν–‰μœΌλ‘œ 이동이 κ°€λŠ₯ν•˜κ³  νŒŒλž€μƒ‰ μœ€κ³½μ„ μ΄ λ‚˜νƒ€λ‚˜λ©°, Enter λ˜λŠ” Space ν‚€λ‘œ 상세 λͺ¨λ‹¬ 창을 λ„μšΈ 수 있음.

β™Ώ μ ‘κ·Όμ„± (Accessibility):

  • ν™”λ©΄ 리더기λ₯Ό μœ„ν•œ λͺ…ν™•ν•œ 폼 λ ˆμ΄λΈ” μ§€μ • μ™„λ£Œ (aria-label)
  • 마우슀λ₯Ό μ‚¬μš©ν•  수 μ—†λŠ” ν™˜κ²½μ„ μœ„ν•œ ν‚€λ³΄λ“œ λ‚΄λΉ„κ²Œμ΄μ…˜(Tab, Enter, Space) 지원 μΆ”κ°€
  • :focus-visible을 ν†΅ν•œ ν‚€λ³΄λ“œ 포컀슀 인지성 κ°•ν™”

PR created automatically by Jules for task 17265402370554056705 started by @seonghobae

… labels

- Added `aria-label` to file input, search input, and severity select.
- Made table rows focusable with `tabindex="0"`.
- Added `keydown` event listener to table rows to trigger detail modal on 'Enter' and 'Space'.
- Added `:focus-visible` styling to table rows for clear visual feedback during keyboard navigation.
- Updated .jules/palette.md with the learnings.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant