๐ก๏ธ Sentinel: [CRITICAL] ๋๋ฝ๋ ๋น๋ฐ ํ ํฐ ๋ง์คํน (Redaction) ์ถ๊ฐ#224
๐ก๏ธ Sentinel: [CRITICAL] ๋๋ฝ๋ ๋น๋ฐ ํ ํฐ ๋ง์คํน (Redaction) ์ถ๊ฐ#224seonghobae wants to merge 1 commit into
Conversation
* `scanner/cli/appguardrail.py`์ `_SENSITIVE_RULE_TOKENS`์ "aws", "private-key", "anthropic", "google", "github", "api-key" ํ ํฐ์ ์ถ๊ฐํ์ต๋๋ค. * ์ด๋ฅผ ํตํด ์๋ก์ด ๋น๋ฐ ๊ฒ์ถ ๊ท์น(AWS ํค, GitHub ํ ํฐ ๋ฑ)์ด ํ์ง๋์์ ๋ ํด๋น ๊ฐ์ด ํฐ๋ฏธ๋์ด๋ CI/CD ๋ก๊ทธ์ ๊ทธ๋๋ก ๋ ธ์ถ๋์ง ์๊ณ "[REDACTED]"๋ก ์์ ํ๊ฒ ๋ง์คํน ์ฒ๋ฆฌ๋ฉ๋๋ค. * `.jules/sentinel.md` ์ ๋์ ์ด๋ฒ ๋ณด์ ํ์ต ๋ด์ฉ์ ์ถ๊ฐํ์ต๋๋ค.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR fixes a security issue where newly added secret scanning rules (such as AWS access keys, GitHub tokens, Anthropic API keys, etc.) were correctly detected by the scanner, but their corresponding identifying tokens were missing from the
_SENSITIVE_RULE_TOKENStuple inscanner/cli/appguardrail.py.Because of this omission, if the scanner found one of these secrets, it would not recognize the rule as a "sensitive rule" and could potentially print the actual secret value in the terminal output or CI/CD logs.
By adding "aws", "private-key", "anthropic", "google", "github", and "api-key" to
_SENSITIVE_RULE_TOKENS, any output from these rules will now be safely redacted as[REDACTED: sensitive match suppressed]. A note was also added to the Sentinel journal (.jules/sentinel.md) about this learning.PR created automatically by Jules for task 3644730199513356947 started by @seonghobae