Skip to content

fix(scheduler): isolate concurrency so merge passes complete instead of being cancelled#343

Merged
seonghobae merged 1 commit into
mainfrom
fix/scheduler-concurrency-isolation
Jul 7, 2026
Merged

fix(scheduler): isolate concurrency so merge passes complete instead of being cancelled#343
seonghobae merged 1 commit into
mainfrom
fix/scheduler-concurrency-isolation

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

문제

중앙 pr-review-merge-schedulerconcurrency.cancel-in-progress: true가 공유 github.ref 그룹에 적용돼, schedule(cron)·workflow_run·push 이벤트가 서로를 취소합니다. 현재 org 전체 오픈 PR ~296개가 쏟아내는 push/synchronize 이벤트로 인해 병합/리뷰 패스가 완료 전에 매번 취소됩니다.

증거: schedule 트리거 스케줄러 실행이 2026-07-06 16:14 ~ 07-07 05:29 전부 cancelled. 결과적으로 org 전체에서 병합 0건, 다수 PR의 리뷰·Security-Scan 체크가 통째로 취소됨.

수정

cancel-in-progress격리된 per-PR 이벤트(pull_request_target, workflow_dispatch)에만 적용. schedule/전체-큐 패스는 취소 대신 직렬 큐잉되어 완료됩니다 → 리뷰 판정이 정상적으로 내려지고 승인된 PR이 병합됩니다.

-  cancel-in-progress: true
+  cancel-in-progress: ${{ github.event_name == 'pull_request_target' || github.event_name == 'workflow_dispatch' }}

per-PR 이벤트는 이미 pr-<number> 격리 그룹이라 그 안에서의 취소는 정상 동작이며, 공유 그룹만 취소가 꺼집니다.

🤖 Generated with Claude Code

…sses are not cancelled

cancel-in-progress was true for the shared github.ref group, so schedule
cron + workflow_run + push events cancelled each other. Under the current
high PR/event volume the merge pass was cancelled before completing, so no
PRs ever merged and review runs were cancelled org-wide. Restrict
cancel-in-progress to isolated per-PR events (pull_request_target,
workflow_dispatch); schedule/queue passes now serialize instead of
cancelling, letting reviews and merges complete.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EywwS2Du8pimW7xqRP3An3
@seonghobae seonghobae merged commit f7de4fa into main Jul 7, 2026
9 of 21 checks passed
@seonghobae seonghobae deleted the fix/scheduler-concurrency-isolation branch July 7, 2026 12:42

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was cancelled, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was cancelled, so required test/docstring evidence was not proven for current head 512c8ea03f7f83778cae4ec51889c9bd47b11d63.

  • Head SHA: 512c8ea03f7f83778cae4ec51889c9bd47b11d63

  • Workflow run: 28859341751

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: pr-review-merge-scheduler.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: pr-review-merge-scheduler.yml"]
  R1 --> V1["actionlint plus required checks"]
Loading

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 512c8ea03f7f83778cae4ec51889c9bd47b11d63
  • Workflow run: 28859341751
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was cancelled, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was cancelled, so required test/docstring evidence was not proven for current head 512c8ea03f7f83778cae4ec51889c9bd47b11d63.

  • Head SHA: 512c8ea03f7f83778cae4ec51889c9bd47b11d63

  • Workflow run: 28859341751

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Workflow: pr-review-merge-scheduler.yml"]
  S1 --> I1["GitHub Actions review job"]
  I1 --> R1["Review risk: Workflow: pr-review-merge-scheduler.yml"]
  R1 --> V1["actionlint plus required checks"]
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant