Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/ci/pr_review_merge_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -552,8 +552,10 @@ def workflow_dispatch_target(repo: str, base_ref: str) -> tuple[str, str, list[s
"i/o timeout",
"server error",
"service unavailable",
"stream error",
"temporary failure",
"timeout",
"received from peer",
)


Expand Down
23 changes: 23 additions & 0 deletions tests/test_pr_review_merge_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,29 @@ def fake_run(args, stdin=None):
assert sleeps == [1, 2]


def test_gh_graphql_retries_transient_http2_stream_cancel(monkeypatch):
calls = []
sleeps = []

def fake_run(args, stdin=None):
calls.append((args, stdin))
if len(calls) == 1:
raise RuntimeError(
"Command failed (1): gh api graphql\n"
"stream error: stream ID 1; CANCEL; received from peer"
)
return '{"data":{"repository":{"pullRequests":{"nodes":[],"pageInfo":{"hasNextPage":false}}}}}'

monkeypatch.setattr(sched, "run", fake_run)
monkeypatch.setattr(sched.time, "sleep", lambda seconds: sleeps.append(seconds))

payload = sched.gh_graphql("query", owner="owner", name="repo", pageSize=100)

assert payload["data"]["repository"]["pullRequests"]["nodes"] == []
assert len(calls) == 2
assert sleeps == [1]


def test_gh_graphql_does_not_retry_non_transient_errors(monkeypatch):
calls = []

Expand Down
Loading