This repository was archived by the owner on Jan 21, 2022. It is now read-only.
Add ERC20 decimal field support#115
Open
wtzb wants to merge 4 commits into
Open
Conversation
|
|
raulk
reviewed
Oct 30, 2018
Contributor
There was a problem hiding this comment.
Thanks for the contribution! Could you maybe add a trivial test here? Could be as simple enhancing the existing tests to request the new field.
https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts
Author
|
Something like this? :)
…On Tue, 30 Oct 2018, 22:47 Raúl Kripalani ***@***.*** wrote:
***@***.**** commented on this pull request.
Thanks for the contribution? Could you maybe add a trivial test here?
Could be as simple enhancing the existing tests to request the new field.
https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK4kAIebiP9IVZOV7uEoioVzROJD2W07ks5uqMjwgaJpZM4YC6Ru>
.
|
Author
|
Awesome, thanks!
…On Tue, 30 Oct 2018, 22:47 Raúl Kripalani ***@***.*** wrote:
***@***.**** commented on this pull request.
Thanks for the contribution? Could you maybe add a trivial test here?
Could be as simple enhancing the existing tests to request the new field.
https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#115 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK4kAIebiP9IVZOV7uEoioVzROJD2W07ks5uqMjwgaJpZM4YC6Ru>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #114