This repository was archived by the owner on Jan 29, 2025. It is now read-only.
Open
Conversation
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started reviewing #1 and thought it might be easier to send this suggestion
This Splits Server and Client connections - this way the Server connection doesn't need permissions but the Client connection can use fine-grained permissions
Instead of storing the JWT and Seed in a cookie, it is requested from the API every time a client needs to make a connection. This makes it a little easier to develop, because creds are refreshed on reload instead of on logout/login.
It also adds a react hook for
useClientNatsConto split out the logic where the client gets a NATS connection. A side effect was that had to be added as a dependency to all of theuseEffectblocks that consume it, and callbacks that consume it had to be switched touseCallbackwith dependencies also.