docs(adr): foundation cleanup — adr-000 non-ADR header reframe#309
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 3, 2026
Merged
Conversation
Phase 1 of the OR-abstraction audit (2026-05-03). One doc-only fix. adr-000-data-model.md is the per-app entity catalogue (39 procest entities), not an architecture decision. Added a non-ADR header citing hydra ADR-001 (data layer) and ADR-022 (apps consume OR abstractions) as the authoritative contract this catalogue operates inside, so future readers don't mistake the OR-built-in fields and capabilities reminder for a duplicate decision (the anti-pattern hydra ADR-022 was written to prevent). Filename rename to `data-model.md` (no `adr-` prefix) is queued for the upcoming procest adoption change.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-03 13:26 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the OR-abstraction audit (2026-05-03). One doc-only fix.
adr-000-data-model.mdis the per-app entity catalogue (39 procest entities), not an architecture decision. Added a non-ADR header citing hydra ADR-001 + ADR-022 so the OR-contract reminder isn't mistaken for a duplicate ADR (the anti-pattern hydra ADR-022 was written to prevent). Filename rename todata-model.mdis queued for the upcoming procest adoption change.Test plan