test(docs-capture): instrument 3 components with stable data-testid#325
Merged
Merged
Conversation
Smoke test of /journeydoc-instrument from hydra (PR #228). Adds 13 purely-additive `data-testid` attributes across the three components the pipelinq capture spec hits hardest. `src/views/clients/ClientCreateDialog.vue`: - client-create-dialog (overlay container) - client-create-close (header X button) `src/views/clients/ClientForm.vue`: - client-form (form root) - client-name-input, client-type-select, client-email-input, client-phone-input, client-website-input, client-address-input, client-notes-input - client-form-save, client-form-cancel `src/components/ProspectCard.vue`: - prospect-card-${prospect.kvkNumber} (per-card unique target, enables drag tests on a specific card) - prospect-create-lead (primary action button) Pure attribute additions — no styling, no behaviour change, no existing test broken (pipelinq has no Vue unit-test runner). Hooks the U2 add-client flow, U3 link contact-person flow, and U4 move-lead-through-pipeline flow in `tests/e2e/docs-screenshots.spec.ts`. The remaining capture stories (U5 contact moments, U6 requests, U7 contacts sync, U8 duplicate resolution, A1-A3 admin) need their own component-instrument pass — follow up via /journeydoc-instrument on: src/views/contactmomenten/ContactmomentForm.vue src/views/widgets/MyLeadsWidget.vue (or its rendering of requests) src/views/settings/PipelineManager.vue src/components/admin/QueueSettings.vue
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-06 14:47 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Smoke test of
/journeydoc-instrumentfrom hydra PR #228. Adds 13 purely-additivedata-testidattributes across the three components the pipelinq capture spec hits hardest.What changed
src/views/clients/ClientCreateDialog.vueclient-create-dialog,client-create-closesrc/views/clients/ClientForm.vueclient-form,client-{name,type,email,phone,website,address,notes}-{input,select},client-form-save,client-form-cancelsrc/components/ProspectCard.vueprospect-card-${kvkNumber}(unique per card),prospect-create-leadPure attribute additions — no styling, no behaviour change, no existing test broken.
Wiring
These hook the U2 add-client flow, U3 link contact-person flow, and U4 move-lead-through-pipeline flow in
tests/e2e/docs-screenshots.spec.ts. The capture spec can now drive the full create-client form end-to-end and target a specific kanban card by KvK number.Follow-up instrumentation
Remaining capture stories need their own component-instrument pass. Suggested next files for
/journeydoc-instrument:src/views/contactmomenten/ContactmomentForm.vue(U5 log contact moment)src/views/widgets/MyLeadsWidget.vue(U6 capture request)src/views/settings/PipelineManager.vue(A1 configure pipeline stages)src/components/admin/QueueSettings.vue(A2 / A3 admin sections)Note on inherited dev-branch CI red
Pipelinq's
developmentbranch is currently red on PHPCS / ESLint / Stylelint / npm-audit / npm-license — pre-existing, unrelated to this PR (see PR #324 conversation). This PR will inherit those failures. Recommend admin merge through them, with a separate fix-CI-quality-gates ticket on the team's docket.