feat(task): add x-openregister-lifecycle to task schema#314
Open
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Open
feat(task): add x-openregister-lifecycle to task schema#314rubenvdlinde wants to merge 3 commits intodevelopmentfrom
rubenvdlinde wants to merge 3 commits intodevelopmentfrom
Conversation
Adds the lifecycle annotation matching CallbackService::ALLOWED_TRANSITIONS: | Action | from | to | |---|---|---| | claim | open | in_behandeling | | complete | in_behandeling | afgerond | | expire | in_behandeling | verlopen | | reopen | afgerond / verlopen | open | Forward-looking documentation: the existing CallbackController returns stub data and never actually persists the task to OpenRegister, so the platform's LifecycleValidationListener has nothing to enforce against yet. When the controller is wired to actually save tasks, the schema's declared transitions become the single source of truth and CallbackService::validateStatusTransition + ALLOWED_TRANSITIONS can be deleted (replaced by the platform listener, same pattern as ConductionNL/decidesk#141 and ConductionNL/docudesk's signingRequest).
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 249/249 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 12% (42 tests / 363 specs)
Quality workflow — 2026-04-29 11:10 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotates task schema with the lifecycle defined in CallbackService::ALLOWED_TRANSITIONS (open/in_behandeling/afgerond/verlopen). Forward-looking: CallbackController returns stub data so the platform's listener has nothing to enforce yet, but once the controller persists through OpenRegister the schema becomes the source of truth. Companion: ConductionNL/openregister#1357