Document admin settings duplicate prevention feature (#182)#219
Draft
rubenvdlinde wants to merge 4 commits intodevelopmentfrom
Draft
Document admin settings duplicate prevention feature (#182)#219rubenvdlinde wants to merge 4 commits intodevelopmentfrom
rubenvdlinde wants to merge 4 commits intodevelopmentfrom
Conversation
Document the implementation of duplicate prevention in TagManager component for lead sources and request channels. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Mark the admin settings duplicate prevention feature as PR-created per the Hydra Builder workflow. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ❌ | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ❌ |
Quality workflow — 2026-04-16 11:41 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ❌ | ✅ 249/249 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-16 11:43 UTC
Download the full PDF report from the workflow artifacts.
rubenvdlinde
added
ready-for-code-review
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 249/249 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 14% (42 tests / 298 specs)
Quality workflow — 2026-04-18 21:59 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 249/249 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 14% (42 tests / 298 specs)
Quality workflow — 2026-04-20 10:40 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182
Summary
This PR documents the implementation of duplicate prevention in the TagManager component used for managing lead sources and request channels in Pipelinq admin settings. The feature prevents users from adding or renaming items to duplicate names (case-insensitive comparison) with clear user feedback through error messages.
Spec Reference
openspec/changes/2026-03-20-admin-settings/design.mdChanges
openspec/changes/2026-03-20-admin-settings/design.md— Comprehensive design documentation for the duplicate prevention feature, including implementation details, user experience flow, testing scope, and acceptance criteriasrc/views/settings/TagManager.vue— Duplicate detection logic in saveNew() and saveRename() methods (previously implemented)l10n/en.json— English translation for duplicate error message (previously implemented)l10n/nl.json— Dutch translation for duplicate error message (previously implemented)Test Coverage
The duplicate prevention feature has been verified to work correctly: