chore(deps): npm audit fix — clear all 6 high-severity vulnerabilities (lockfile-only)#81
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 1, 2026
Merged
Conversation
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ❌ 1/498 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| apexcharts | 5.10.6 | Custom: https://apexcharts.com/media/apexcharts-logo.png |
Quality workflow — 2026-05-01 07:56 UTC
Download the full PDF report from the workflow artifacts.
Lockfile-only update via `npm audit fix` (no --force, no package.json changes, no major bumps). Resolves every high-severity npm vulnerability flagged on the development branch: - fast-xml-parser CVE chain (incl. Dependabot alerts #52, #70): 4.5.4 → 4.5.6 (entity-expansion bypass + comment/CDATA injection) - lodash prototype pollution - node-forge prototype pollution - path-to-regexp ReDoS - picomatch ReDoS As a side effect npm chose @conduction/nextcloud-vue 0.1.0-beta.15 (was beta.3), picking up the 12 intervening upstream releases including all the recent CnAppNav/CnAppRoot work. The Nc* re-export issue blocking eslint is unaffected — that lands when nextcloud-vue PR #102 ships and a new beta is published. Remaining: 12 moderate + 32 low. All require major-version bumps (@nextcloud/webpack-vue-config v7, vue-loader v17, @vue/test-utils v2 which is Vue-3-only and would break the app, etc.) — out of scope for an audit-fix sweep, deserve dedicated PRs with build/test verification. Verified locally: - `npm run build` succeeds (35 webpack warnings, same baseline as dev) - `npm run lint` no new errors (the 32 Nc* `import/named` errors are pre-existing, fixed by nextcloud-vue PR #102) - `npm audit` reports 0 high-severity vulnerabilities (was 6)
rubenvdlinde
force-pushed
the
chore/npm-audit-fix-h6
branch
from
708745e to
773a22d
Compare
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ❌ 1/498 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| apexcharts | 5.10.6 | Custom: https://apexcharts.com/media/apexcharts-logo.png |
Quality workflow — 2026-05-01 08:07 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 1, 2026
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
#81) Lockfile-only update via `npm audit fix` (no --force, no package.json changes, no major bumps). Resolves every high-severity npm vulnerability flagged on the development branch: - fast-xml-parser CVE chain (incl. Dependabot alerts #52, #70): 4.5.4 → 4.5.6 (entity-expansion bypass + comment/CDATA injection) - lodash prototype pollution - node-forge prototype pollution - path-to-regexp ReDoS - picomatch ReDoS As a side effect npm chose @conduction/nextcloud-vue 0.1.0-beta.15 (was beta.3), picking up the 12 intervening upstream releases including all the recent CnAppNav/CnAppRoot work. The Nc* re-export issue blocking eslint is unaffected — that lands when nextcloud-vue PR #102 ships and a new beta is published. Remaining: 12 moderate + 32 low. All require major-version bumps (@nextcloud/webpack-vue-config v7, vue-loader v17, @vue/test-utils v2 which is Vue-3-only and would break the app, etc.) — out of scope for an audit-fix sweep, deserve dedicated PRs with build/test verification. Verified locally: - `npm run build` succeeds (35 webpack warnings, same baseline as dev) - `npm run lint` no new errors (the 32 Nc* `import/named` errors are pre-existing, fixed by nextcloud-vue PR #102) - `npm audit` reports 0 high-severity vulnerabilities (was 6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lockfile-only update via `npm audit fix` (no `--force`, no `package.json` edits, no major bumps). Clears every high-severity npm vulnerability flagged on `development`.
What got patched
Out of scope
The remaining 12 moderate + 32 low alerts all require major-version bumps that warrant their own PR + build/test cycle:
Verified locally
Test plan
Diff size note
The `package-lock.json` diff is ~2569 lines — that's auto-generated noise as npm rebuilds the resolution graph. The actionable changes are the version table above; reviewing the lockfile line by line is not productive. `npm audit` exit code is the meaningful gate.