fix(phpcs): clear PageController + ResponseHelper formatting errors blocking release#75
Merged
rubenvdlinde merged 1 commit intodevelopmentfrom May 1, 2026
Merged
Conversation
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-01 06:11 UTC
Download the full PDF report from the workflow artifacts.
…eHelper - Apply phpcbf autofix for parameter-name + type spacing alignment in the docblocks (17 violations). - Replace the inline ternary on PageController:101 with an explicit if-block; inline IF statements are blocked by the project sniffs and the line was 136 chars (over the 125 limit). Unblocks the release PR (#72) which was failing the `quality / PHP Quality (phpcs)` check.
rubenvdlinde
force-pushed
the
fix/phpcs-controller-formatting
branch
from
d6f50c8 to
140bf22
Compare
Contributor
Quality Report — ConductionNL/mydash @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 342/342 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-01 08:01 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 1, 2026
rubenvdlinde
added a commit
that referenced
this pull request
May 3, 2026
…eHelper (#75) - Apply phpcbf autofix for parameter-name + type spacing alignment in the docblocks (17 violations). - Replace the inline ternary on PageController:101 with an explicit if-block; inline IF statements are blocked by the project sniffs and the line was 136 chars (over the 125 limit). Unblocks the release PR (#72) which was failing the `quality / PHP Quality (phpcs)` check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks PR #72 (release: development → beta) which is failing on `quality / PHP Quality (phpcs)`.
After the change `composer phpcs` (i.e. `./vendor/bin/phpcs --standard=phpcs.xml`) reports zero errors across all 49 scanned files.
Test plan