Skip to content

ADD docker_iblgf.sh --pull flag#29

Merged
YellowHowler merged 3 commits intomainfrom
rc_old_docker
May 1, 2026
Merged

ADD docker_iblgf.sh --pull flag#29
YellowHowler merged 3 commits intomainfrom
rc_old_docker

Conversation

@YellowHowler
Copy link
Copy Markdown
Contributor

No description provided.

@YellowHowler YellowHowler marked this pull request as draft April 30, 2026 05:19
@YellowHowler YellowHowler marked this pull request as ready for review April 30, 2026 05:19
FIX run output folder timezone mismatch
Copy link
Copy Markdown
Collaborator

@CarolineCardinale CarolineCardinale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put the copy.sh files in iblgf-viewer repo instead?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed in main repo?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I thought it needed to be but apparently not. I just moved them to the viewer repo now.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was still merged into the main repo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request included my previous changes so it should have merged and then deleted I think. For me I don't see the copy scripts in main right now. Are they still there?

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i meant the .iblgf_viewer/ files

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the copy there are the original bash scripts that works in the IBLGF_AMR repo. I had to edit some stuff in the bash scripts to make them work inside the iblgf_viewer so I kept the copies to have a backup of the originals.

@CarolineCardinale CarolineCardinale removed their request for review May 1, 2026 18:34
@YellowHowler YellowHowler merged commit 5326378 into main May 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants