Skip to content

CMP-3790: Add test for remediation status 'NeedsReview' (46525)#1022

Draft
Anna-Koudelkova wants to merge 1 commit intoComplianceAsCode:masterfrom
Anna-Koudelkova:CMP-3790
Draft

CMP-3790: Add test for remediation status 'NeedsReview' (46525)#1022
Anna-Koudelkova wants to merge 1 commit intoComplianceAsCode:masterfrom
Anna-Koudelkova:CMP-3790

Conversation

@Anna-Koudelkova
Copy link
Copy Markdown
Collaborator

@Anna-Koudelkova Anna-Koudelkova commented Dec 8, 2025

Adding testcase OCP-46525 to upstream. Currently it is not working, not sure why. My best current guess is the problem might be the image that it is using, because right now even the downstream version of the test is failing with the same error message:

=== RUN   TestRemediationNeedsReview
2025/12/08 14:22:34 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:38 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:44 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:49 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:54 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:58 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:04 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:08 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:13 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:18 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:24 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: AGGREGATING
2025/12/08 14:23:29 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: AGGREGATING
    main_test.go:2210: expecting NON-COMPLIANT got NOT-APPLICABLE
--- FAIL: TestRemediationNeedsReview (65.79s)
FAIL
FAIL	github.com/ComplianceAsCode/compliance-operator/tests/e2e/serial	258.699s
FAIL

Question I am solving right now: How do I find out if the image is okay, or not?

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@Anna-Koudelkova: This pull request references CMP-3790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Adding testcase OCP-46525 to upstream. Currently it is not working, not sure why. My best current guess is the problem might be the image that it is using, because right now even the downstream version of the test is failing with the same error message:

=== RUN   TestRemediationNeedsReview
2025/12/08 14:22:34 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:38 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:44 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:49 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:54 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:22:58 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:04 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:08 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:13 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:18 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: RUNNING
2025/12/08 14:23:24 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: AGGREGATING
2025/12/08 14:23:29 waiting until suite test-remediation-needs-review reaches target status 'DONE'. Current status: AGGREGATING
   main_test.go:2210: expecting NON-COMPLIANT got NOT-APPLICABLE
--- FAIL: TestRemediationNeedsReview (65.79s)
FAIL
FAIL	github.com/ComplianceAsCode/compliance-operator/tests/e2e/serial	258.699s
FAIL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Anna-Koudelkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 8, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1022-be3cdb2bfae73519d90c9038897a3232765171a7

@rhmdnd rhmdnd self-requested a review March 2, 2026 17:35
Scans: []compv1alpha1.ComplianceScanSpecWrapper{
{
ComplianceScanSpec: compv1alpha1.ComplianceScanSpec{
ContentImage: "quay.io/openshifttest/co_content:qe_remediation_variable",
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is pretty old - I wonder if that's part of the problem?

https://quay.io/repository/openshifttest/co_content?tab=tags&tag=latest

Is there a container file where we can see how this image was built? Or, can we upstream that too and rebuild the image?

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 9, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants