Skip to content

CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate#1021

Open
xiaojiey wants to merge 1 commit intoComplianceAsCode:masterfrom
xiaojiey:enhance-TestScheduledSuiteUpdate
Open

CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate#1021
xiaojiey wants to merge 1 commit intoComplianceAsCode:masterfrom
xiaojiey:enhance-TestScheduledSuiteUpdate

Conversation

@xiaojiey
Copy link
Copy Markdown
Collaborator

@xiaojiey xiaojiey commented Dec 8, 2025

  1. Enhance TestScheduledSuiteUpdate by adding resource verification for suitererunner jobs
  2. Enhance TestScheduledSuiteUpdate by adding compliancesuite rerun check after schedule update

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaojiey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Dec 8, 2025
@xiaojiey xiaojiey changed the title Enhance TestScheduledSuiteUpdate by adding resource verification for … CMP-3795: Enhance TestScheduledSuiteUpdate by adding resource verification for suitererunner jobs Dec 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@xiaojiey: This pull request references CMP-3795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

…suitererunner Jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-0274f40ccf27f61e6f882b2521670c533585b627

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 8, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-3ce31166a40158fdee63804940433d6854b423eb

@xiaojiey xiaojiey changed the title CMP-3795: Enhance TestScheduledSuiteUpdate by adding resource verification for suitererunner jobs CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate Dec 8, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@xiaojiey: This pull request references CMP-3795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

This pull request references CMP-3796 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  1. Enhance TestScheduledSuiteUpdate by adding resource verification for suitererunner jobs
  2. Enhance TestScheduledSuiteUpdate by adding currentIndex check after schedule updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiaojiey xiaojiey changed the title CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate [WIP]CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate Dec 8, 2025
@xiaojiey xiaojiey force-pushed the enhance-TestScheduledSuiteUpdate branch from 3ce3116 to c05f001 Compare December 9, 2025 00:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 9, 2025

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-c05f001cf319877e8d286f59f4ece6f18aec97ce

@xiaojiey xiaojiey changed the title [WIP]CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate CMP-3795, CMP-3796: Enhance TestScheduledSuiteUpdate Dec 9, 2025
@xiaojiey
Copy link
Copy Markdown
Collaborator Author

/test e2e-aws-serial

@openshift-ci-robot
Copy link
Copy Markdown
Collaborator

@xiaojiey: This pull request references CMP-3795 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

This pull request references CMP-3796 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  1. Enhance TestScheduledSuiteUpdate by adding resource verification for suitererunner jobs
  2. Enhance TestScheduledSuiteUpdate by adding compliancesuite rerun check after schedule updated

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Anna-Koudelkova
Copy link
Copy Markdown
Collaborator

/lgtm

@Anna-Koudelkova
Copy link
Copy Markdown
Collaborator

Verification passed on 4.21 cluster as well:

2026/01/22 13:49:05 Suite rerunner job test-scheduled-suite-update-rerunner-29484768 has correct resource limits and requests
--- PASS: TestScheduledSuiteUpdate (252.96s)
PASS

@taimurhafeez
Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 23, 2026

@taimurhafeez: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@taimurhafeez
Copy link
Copy Markdown
Collaborator

taimurhafeez commented Jan 23, 2026

Test passed on 4.21 cluster:

2026/01/23 11:47:06 ComplianceScan ready (DONE) 2026/01/23 11:47:06 Suite rerunner job test-scheduled-suite-update-rerunner-29486144 has correct resource limits and requests --- PASS: TestScheduledSuiteUpdate (266.55s) PASS

@xiaojiey
Copy link
Copy Markdown
Collaborator Author

xiaojiey commented Mar 4, 2026

/retest

@xiaojiey xiaojiey force-pushed the enhance-TestScheduledSuiteUpdate branch from c05f001 to ff49adc Compare March 4, 2026 02:27
@openshift-ci openshift-ci Bot removed the lgtm label Mar 4, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 4, 2026

New changes are detected. LGTM label has been removed.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 4, 2026

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-ff49adc456fb468f474bb8eda4a291799094b3b1

@xiaojiey xiaojiey force-pushed the enhance-TestScheduledSuiteUpdate branch from ff49adc to e81071f Compare March 6, 2026 04:04
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 6, 2026

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-e81071f71e2c39e24472b56328c500a9b62f02b0

@xiaojiey xiaojiey force-pushed the enhance-TestScheduledSuiteUpdate branch from e81071f to d31789f Compare March 23, 2026 06:04
@xiaojiey xiaojiey requested review from rhmdnd and yuumasato March 23, 2026 06:04
…suitererunner Jobs

Ensuring the suite schedule works after the schedule change
@github-actions
Copy link
Copy Markdown

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1021-d31789fb26b2a00612d55b99a1030016472d03cd

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 23, 2026

@xiaojiey: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa d31789f link true /test e2e-rosa
ci/prow/e2e-aws-parallel d31789f link true /test e2e-aws-parallel
ci/prow/e2e-aws-parallel-arm d31789f link true /test e2e-aws-parallel-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 2, 2026

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@taimurhafeez
Copy link
Copy Markdown
Collaborator

Has been superseded and re-based in 1185.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants