POC: AOT compatible ObservableValidator#1181
Open
OleRoss wants to merge 7 commits intoCommunityToolkit:mainfrom
Open
POC: AOT compatible ObservableValidator#1181OleRoss wants to merge 7 commits intoCommunityToolkit:mainfrom
OleRoss wants to merge 7 commits intoCommunityToolkit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1180
This PR serves as a prototype to showcase a working ObservableValidator that is fully AOT compatible (please see the AOT unit tests for that). Additionally, I have added
CommunityToolkit.Mvvm.Aot.UnitTestswhich can be run using e.g.tests/CommunityToolkit.Mvvm.Aot.UnitTests/TestAot.ps1Right now, there are the following (breaking?) changes:
Fallbacktests fail (there would be no reflection-heavy fallback anymore)Validatorlogic for discovering attributes, ... there might be differences in the way we discover attributes / doing the exact validationPR Checklist
Other information
Please note that I would not want to merge the generator in its current state. It only serves as a proof-of-concept that the tests can be green with AOT and is almost fully vibe-coded. If there is interest from the maintainers in pushing this forward, I would be willing to put in the time to properly integrate the generator and cleanup the generated code.