Relay command sg field keywords#1162
Draft
Avid29 wants to merge 3 commits intoCommunityToolkit:mainfrom
Draft
Conversation
Contributor
Author
|
Sorry. This PR is horribly named, but GitHub isn't letting me edit for some reason |
Contributor
Author
|
Some tests are failing. It appears to be because they test that both the field and property is generated, except now a field is no longer always generated. For example: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Closes #1073 **
When the C# language version supports it, this change replaces the backing field for generated
RelayCommands with an implicit field using the newfieldkeyword.PR Checklist
Other information
Technically, this is a breaking change since someone may have been using the backing fields for whatever reason