Skip to content

Change deleted field to DATETIME and use CURRENT_TIMESTAMP #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikigoalie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change deleted field to DATETIME and use CURRENT_TIMESTAMP #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/player/db.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ export function SaveCharacterData(values: any[] | any[][], batch?: boolean) {
}

export async function DeleteCharacter(charId: number) {
return (await db.update('UPDATE characters SET deleted = curdate() WHERE charId = ?', [charId])) === 1;
return (await db.update('UPDATE characters SET deleted = CURRENT_TIMESTAMP() WHERE charId = ?', [charId])) === 1;
}

export function GetCharacterMetadata(charId: number) {
Expand Down
2 changes: 1 addition & 1 deletion sql/install.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ CREATE TABLE IF NOT EXISTS `characters`
`armour` TINYINT UNSIGNED NULL,
`statuses` LONGTEXT COLLATE utf8mb4_bin DEFAULT JSON_OBJECT() NOT NULL
CHECK (JSON_VALID(`statuses`)),
`deleted` DATE NULL,
`deleted` DATETIME NULL,
CONSTRAINT `characters_stateId_unique`
UNIQUE (`stateId`),
CONSTRAINT `characters_userId_fk`
Expand Down