ISSUE-65: Fixed sending of multiple string attachments in Exchange emails#66
Open
HiQ-wipa wants to merge 3 commits intoCommunityHiQ:masterfrom
Open
ISSUE-65: Fixed sending of multiple string attachments in Exchange emails#66HiQ-wipa wants to merge 3 commits intoCommunityHiQ:masterfrom
HiQ-wipa wants to merge 3 commits intoCommunityHiQ:masterfrom
Conversation
added 2 commits
March 1, 2024 17:55
* Exchange emails with two string attachments no longer duplicates the first attachment. * Added test case that sends an exchange email with two string attachments. * Simplified attachment testing by moving directory handling into SetUp and TearDown. * Made tests poll for arrived emails up to 5 times.
HiQ-wipa
changed the title
Svenskapojkarna
requested changes
Mar 13, 2024
Contributor
Svenskapojkarna
left a comment
Svenskapojkarna
left a comment
There was a problem hiding this comment.
https://github.com/HiQ-wipa/Frends.Community.Email/blob/master/Frends.Community.Email/Frends.Community.Email.csproj#L13
Please update version to 4.2.2.
https://github.com/HiQ-wipa/Frends.Community.Email/blob/master/README.md#change-log
Please also update changelog.
Svenskapojkarna
approved these changes
Mar 14, 2024
Contributor
|
The change is approved, but it seems that unit test for sending an email on behalf of other user has broken, which will also block the release of the new version. I'm debugging this issue at the moment and will merge this once the unit test has been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #65.
All SendExchangeEmailTests passed, except SendEmailAsAnotherUserTest, which I'm unable to test since I only have access to one email account.