Skip to content

Fix the larping bundle by clearing object entity from entity manager #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rjzondervan wants to merge 4 commits into
base: feature/oc-bundle
Choose a base branch
from
Open

Fix the larping bundle by clearing object entity from entity manager #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89c88b7
Clear ObjectEntity from Entity Manager
rjzondervan Jan 25, 2023
bf7d9f3
fix for executing installationService->install
bbrands02 Jan 25, 2023
0edc002
Apply fixes from StyleCI
StyleCIBot Jan 25, 2023
70e4652
Merge pull request #134 from CommonGateway/analysis-YOBlQA
bbrands02 Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions Command/InstallCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
{
$this->installationService->setStyle(new SymfonyStyle($input, $output));

$bundle = $input->getArgument('bundle');
$data = $input->getArgument('data');
$noSchema = $input->getOption('schema');
$script = $input->getOption('script');
$unsafe = $input->getOption('unsafe');

return $this->installationService->install($bundle, $noSchema);
return $this->installationService->install($input->getArgument('bundle'), [
'data' => $input->getArgument('data'),
'noSchema' => $input->getOption('schema'),
'script' => $input->getOption('script'),
'unsafe' => $input->getOption('unsafe'),
]);
}
}
1 change: 1 addition & 0 deletions Service/InstallationService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ private function saveOnFixedId(ObjectEntity $objectEntity, array $hydrate = []):
$objectEntity->setId($id);
$this->em->persist($objectEntity);
$this->em->flush();
$this->em->clear(get_class($objectEntity));
$objectEntity = $this->em->getRepository('App:ObjectEntity')->findOneBy(['id' => $id]);

$this->io->writeln(['Defintive object id ('.$objectEntity->getId().')']);
Expand Down
2 changes: 1 addition & 1 deletion Service/RequestService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,7 +443,7 @@ public function requestHandler(array $data, array $configuration): Response
$responseLog = new Response(is_string($this->content) || is_null($this->content) ? $this->content : null, 200, ['CoreBundle' => 'GetItem']);
$session = new Session();
$session->set('object', $this->id);

// todo: This log is needed so we know an user has 'read' this object
$this->logService->saveLog($this->logService->makeRequest(), $responseLog, 15, is_array($this->content) ? json_encode($this->content) : $this->content);
} else {
Expand Down