Conversation
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
4 times, most recently
from
58069c9 to
7702594
Compare
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
7702594 to
ebd724c
Compare
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
ebd724c to
619487d
Compare
PringlesGang
requested changes
Jan 11, 2026
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
619487d to
62a0164
Compare
PringlesGang
requested changes
Jan 11, 2026
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
2 times, most recently
from
fd5dda1 to
6a771bf
Compare
Enorovan
approved these changes
Jan 14, 2026
Member
Enorovan
left a comment
Enorovan
left a comment
There was a problem hiding this comment.
The Select Animations sure are better and the missing inputs in Sound Menu work
KKhanhH
requested changes
Jan 15, 2026
Collaborator
KKhanhH
left a comment
KKhanhH
left a comment
There was a problem hiding this comment.
What's the behavioral changes for the music menu scrolling? Do cross input interactions work well, like scrollbar partial scroll then switch to kb/gamepad, backing out and in from a partial scroll, scroll hold, etc
| inline uint8_t ButterflyFrameCount; | ||
| inline float ButterflyFlapFrameDuration; | ||
| inline float ButterflyFadeDuration; | ||
| inline float MenuSelectPromptDuration; |
Collaborator
There was a problem hiding this comment.
These would be much better suited in a common menu profile file but thats not in yet so I'll let it slide
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
5c7c532 to
4846e24
Compare
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
4846e24 to
dc3b693
Compare
KKhanhH
reviewed
Jan 21, 2026
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
dc3b693 to
2b4e5b5
Compare
KKhanhH
approved these changes
Jan 23, 2026
PringlesGang
approved these changes
Jan 25, 2026
Sound: - Add scrollbar support - Add click support for switching playback mode - Fix misaligned elements and animations Tips: - Start with right page - Fix sprites bounds System Messages: - Fix 1px sprite gap for a button Sound, Movie, CG: - Add "Select ***" animation based on the Tip's menu "Select Word" animation Sound, Movie, CG, Save/Load: - Simplify sprite loading for "Select ***" in .lua Tips, Save/Load, Title, Sound, Movie, CG: - Use one implementation for all "Select ***" animation (via composition) Backlog, Clear, Tips, Save/Load, Title, Sound, Movie, CG, Options, Trophy: - Use one implementation for "Show Menu" animation taken from Options menu (via composition) Bonus: - Shave off 16 bytes of every Animation (Widget has Animation field) - Shave off 8 bytes of every Menu
Gunoshozo
force-pushed
the
chlcc/music-menu-polish
branch
from
1cb2085 to
06fe1c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHLCC: Menus Polish
Sound:
Tips:
Sound, Movie, CG:
Sound, Movie, CG, Save/Load:
Tips, Save/Load, Title, Sound, Movie, CG:
Backlog, Clear, Tips, Save/Load, Title, Sound, Movie, CG, Options, Trophy:
Bonus: