Remove ETapestry import work #1247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwahammy
force-pushed
the
remove-reassignment
branch
from
dbe6fd9 to
9e9b16b
Compare
jrmehle
approved these changes
Aug 28, 2025
jrmehle
left a comment
jrmehle
left a comment
There was a problem hiding this comment.
LGTM. I did have the thought of what if someone comes to us in the future and says they want to hand ETapestry imports. I trust your judgement more than mine given your history with this project.
Member
Author
I doubt we'd be able to reuse a lot but if we wanted to, we still have it in the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point, for one of our clients, they wanted to import from ETapestry. The import was pretty difficult to do and pretty much a one off. When working on a separate PR #1246, I broke one of the etapestry specs. It seems wiser to just remove that code entirely (along with the database tables) and reduce our support burden.
NOTE: DO NOT discuss internal CommitChange information in your PR; this PR will be public.
Link back to the issue in the Tix repo when you need to do that.