release: denote AOSP source ref in release title + notes#2
Merged
Conversation
The release name is the build-tools version (platform-tools-X.Y.Z), but since AOSP's android-NN.0.0_rN scheme the source actually built from diverges from it — platform-tools-37.0.0 is built from android-17.0.0_r1. The notes hardcoded "Built from upstream AOSP tag $TAG", which printed the release name rather than the source. Use the detect job's source_ref instead, and append it to the title when the two differ (legacy releases where source_ref == tag are unchanged). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1. The published
platform-tools-37.0.0release said "Built from upstream AOSP tagplatform-tools-37.0.0" — but that's the release/build-tools name, not the source. It was actually built fromandroid-17.0.0_r1.This fixes the
releasejob so the notes + title reflect the real AOSP source ref (needs.detect.outputs.source_ref):android-17.0.0_r1."platform-tools-37.0.0 (linux-arm64) · android-17.0.0_r1. Legacy releases where the source ref equals the tag (e.g.platform-tools-35.0.2) are unchanged — no redundant suffix.Affects future releases only; I've separately edited the live
platform-tools-37.0.0release to match.🤖 Generated with Claude Code