fix: pass status filter in search index build for preview deploys#753
Draft
dante01yoon wants to merge 1 commit intomainfrom
Draft
fix: pass status filter in search index build for preview deploys#753dante01yoon wants to merge 1 commit intomainfrom
dante01yoon wants to merge 1 commit intomainfrom
Conversation
build-index.ts was calling /api/hub/workflows/index without a ?status= parameter, while hub-api.ts listWorkflowIndex() passes explicit status filters. On the test API (used by preview builds), the default response without status filter returns no workflows, producing an empty search index. Production was unaffected because the prod API has approved workflows returned by default. Also fall back to content collection when the API returns an empty array instead of treating [] as a successful result.
Contributor
🧹 Lint & Format Results
Generated by Site CI workflow |
Contributor
|
🚀 Preview deployed: https://workflow-templates-agxrhvc2b-comfyui.vercel.app |
Contributor
🔍 SEO Audit Results
📊 SEO Audit DetailsCould not parse SEO output 🔗 Link Check Detailsbroken internal links out of checked Generated by Site CI workflow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build-index.tswas calling/api/hub/workflows/indexwithout?status=, whilehub-api.tslistWorkflowIndex()passes explicit status filterssearch-index.json(0 documents) → text search completely broken on preview[]from API was treated as truthy, skipping the content collection fallbackChanges
?status=query parameter matchinghub-api.tslogic (PUBLIC_APPROVED_ONLYenv var)Test plan
search-index.jsonhas documents (not 245 bytes)🤖 Generated with Claude Code