-
Notifications
You must be signed in to change notification settings - Fork 3
feat: pyisolate 0.10.0 — conda backend, sealed workers, CUDA wheels, sandbox hardening #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -107,6 +107,10 @@ async def async_entrypoint( | |||||||||||||||||||
| api_instance = cast(ProxiedSingleton, getattr(api, "instance", api)) | ||||||||||||||||||||
| _adapter.handle_api_registration(api_instance, rpc) | ||||||||||||||||||||
|
|
||||||||||||||||||||
| # Let the adapter wire child-side event hooks (e.g., progress bar) | ||||||||||||||||||||
| if _adapter and hasattr(_adapter, "setup_child_event_hooks"): | ||||||||||||||||||||
| _adapter.setup_child_event_hooks(extension) | ||||||||||||||||||||
|
|
||||||||||||||||||||
|
Comment on lines
+110
to
+113
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Guard adapter hook failures so child startup doesn’t hard-fail. If Proposed fix- # Let the adapter wire child-side event hooks (e.g., progress bar)
- if _adapter and hasattr(_adapter, "setup_child_event_hooks"):
- _adapter.setup_child_event_hooks(extension)
+ # Let the adapter wire child-side event hooks (e.g., progress bar)
+ if _adapter and hasattr(_adapter, "setup_child_event_hooks"):
+ try:
+ _adapter.setup_child_event_hooks(extension)
+ except Exception as exc: # pragma: no cover - best-effort hook
+ logger.warning("Adapter child event hook setup failed: %s", exc, exc_info=True)📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
| # Sanitize module name for use as Python identifier. | ||||||||||||||||||||
| # Replace '-' and '.' with '_' to prevent import errors when module names contain | ||||||||||||||||||||
| # non-identifier characters (e.g., "my-node" → "my_node", "my.node" → "my_node"). | ||||||||||||||||||||
|
|
||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sealed-worker sandbox docs are out of sync with the code.
These lines say sealed workers have “no sandbox” /
bwrapis disabled, but the new Linux tests in this PR assert the opposite for theuvpath: sealed workers still go throughbuild_bwrap_command()with--clearenv, env allowlisting, and read-only binds. Please scope that claim to the conda path or rephrase it so the docs don’t surprise and improvise.🤖 Prompt for AI Agents