Skip to content

fix(ci): publish from single build leg to avoid wheel content conflicts#8

Merged
pollockjj merged 1 commit intoComfy-Org:mainfrom
pollockjj:fix/build-wheels-dedup
Mar 12, 2026
Merged

fix(ci): publish from single build leg to avoid wheel content conflicts#8
pollockjj merged 1 commit intoComfy-Org:mainfrom
pollockjj:fix/build-wheels-dedup

Conversation

@pollockjj
Copy link
Copy Markdown
Collaborator

Summary

Pure Python package produces py3-none-any wheel — identical filename from all 9 build matrix legs but non-identical content (timestamps, metadata ordering). The publish job's dedup check fails on content mismatch.

Fix: download artifacts from a single build leg (ubuntu-latest py3.11) for publish, matching the smoke-test approach.

Test plan

  • Full CI matrix validated (38/38 pass)

Pure Python package produces py3-none-any wheel — identical filename
from all 9 matrix legs but non-identical content (timestamps, metadata
ordering). Use ubuntu-latest py3.11 artifacts only, matching smoke-test.
Copilot AI review requested due to automatic review settings March 12, 2026 02:36
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8b98e67b-97b8-466c-bf0a-fc821732fd97

📥 Commits

Reviewing files that changed from the base of the PR and between 34db809 and 1868078.

📒 Files selected for processing (1)
  • .github/workflows/build-wheels.yml

📝 Walkthrough

Walkthrough

GitHub Actions workflow in the build-wheels pipeline is simplified to use a named artifact download (dist-ubuntu-latest-py3.11) instead of pattern-based retrieval, eliminates local file deduplication logic, and renames the collection step to verification while streamlining the subsequent validation process.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow Configuration
.github/workflows/build-wheels.yml
Updated artifact download strategy from generic pattern matching to named artifact; removed local distribution consolidation and file deduplication logic; renamed "Collect distributions" step to "Verify distributions"; simplified verification to operate directly on downloaded dist directory.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the release publish workflow to avoid artifact deduplication failures caused by multiple matrix legs producing the same py3-none-any wheel filename with non-identical byte content.

Changes:

  • Downloads distributions for publishing from a single build artifact (dist-ubuntu-latest-py3.11) instead of aggregating all matrix artifacts.
  • Removes the publish-time artifact collection/deduplication logic and replaces it with a simpler “verify distributions exist” check.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 60.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pollockjj pollockjj merged commit c5e6e1a into Comfy-Org:main Mar 12, 2026
59 of 60 checks passed
@pollockjj pollockjj deleted the fix/build-wheels-dedup branch March 15, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants