-
Notifications
You must be signed in to change notification settings - Fork 3
feat: isolation serialization, CUDA IPC hardening, and CUDA wheel resolution (v0.9.2) #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pollockjj
merged 4 commits into
Comfy-Org:main
from
pollockjj:pr/0.9.2-isolation-support
Mar 12, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2641b45
feat(cuda-wheels): resolve runtime-matched CUDA wheels from custom in…
pollockjj 3bd5249
feat: isolation serialization improvements for custom node support
pollockjj 62c8cfa
test: unit tests for serialization registry, transport limits, and de…
pollockjj 7e407d0
chore: bump version to 0.9.2
pollockjj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error message lists optional dependency;
run_benchmarksreturn value is ignored.Two minor issues:
Line 350 mentions
tabulatein the required dependencies message, buttabulateis optional (handled gracefully viaTABULATE_AVAILABLE). Consider updating the message to only list truly required dependencies.Line 353 calls
run_benchmarks()which returns0, but this return value is ignored. Line 354 unconditionally returns0. Ifrun_benchmarksis intended to signal success/failure via its return value, propagate it.Proposed fix
if find_spec("numpy") is None or find_spec("psutil") is None: - print("Please install dependencies: pip install numpy psutil tabulate") + print("Please install dependencies: pip install numpy psutil") + print("Optional: pip install tabulate (for formatted output)") return 1 - asyncio.run(run_benchmarks(args.quick, args.no_torch, args.no_gpu, args.torch_mode)) - return 0 + return asyncio.run(run_benchmarks(args.quick, args.no_torch, args.no_gpu, args.torch_mode))📝 Committable suggestion
🤖 Prompt for AI Agents