feat: add unauthenticated user handling for Giscus comments #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
comfyui-wiki
commented
Dec 29, 2025
comfyui-wiki
commented
- Add unauthenticated notice type with login prompt
- Distinguish between unauthenticated rate limits and authenticated rate limits
- Show login suggestion when unauthenticated users hit rate limits
- Detect authentication errors and show appropriate notices
- Add debug function to test unauthenticated notice
- Improve error detection to check for auth-related messages in iframe content
- Add unauthenticated notice type with login prompt - Distinguish between unauthenticated rate limits and authenticated rate limits - Show login suggestion when unauthenticated users hit rate limits - Detect authentication errors and show appropriate notices - Add debug function to test unauthenticated notice - Improve error detection to check for auth-related messages in iframe content
- Consolidate notice types into a single function to streamline error handling. - Remove specific notice types for rate limits, unauthenticated users, and network errors; now always show a unified notice. - Enhance Chinese language support for notices. - Update debug functions to reflect changes in notice handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.