Skip to content

Conversation

@beyandbey
Copy link

Fixes #311

comfy launch used to detect Workspace.CURRENT_DIR when launched from within the directory marked as default.
This lead to some unexpected behavior, i.e. not being able to apply default launch extras.

When working from within the default workspace, I'd assume the user wants to apply default settings as well. Hence following changes:

  • detect WorkspaceType.DEFAULT when run from default directory
  • use --here to detect as WorkspaceType.CURRENT_DIR instead (and hence ignore default setttings)

This makes working within the default workspace more convenient, whilst preserving the possibility to opt-out of default behavior.

- detect WorkspaceType.DEFAULT when run from default directory
- use --here to detect as WorkspaceType.CURRENT_DIR instead
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Nov 11, 2025
@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comfy_cli/workspace_manager.py 42.85% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main     #338      +/-   ##
==========================================
- Coverage   52.18%   52.15%   -0.04%     
==========================================
  Files          32       32              
  Lines        3516     3520       +4     
==========================================
+ Hits         1835     1836       +1     
- Misses       1681     1684       +3     
Files with missing lines Coverage Δ
comfy_cli/workspace_manager.py 62.87% <42.85%> (-0.93%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bigcat88 bigcat88 self-requested a review November 16, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

default_launch_extras configuration not being applied when using 'comfy launch'

1 participant