Removing pypi check_for_updates from commands where it halts offline execution
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can we change the check_for_update function to fail gracefully instead? |
Author
I think thats a reasonable solution if its very fast to fail gracefully. Otherwise we will have every command hanging for seconds while it waits trying to have a conversation with the pypi servers, and that would reduce performance in some deployments. |
Author
|
I've submitted a new PR following @robinjhuang suggestion to add a timeout and fail quietly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking the version of comfy-cli in commands where internet-access is not necessary, such as
comfy launchandcomfy envcauses comfy-cli to hang in a docker container (or offline) environment.I opened an issue to describe this
#175
This PR removes just those calls to
check_for_updates()that ping pypi each time acomfy launchis run or acomfy envis checked where offline operation can otherwise work perfectly.