Skip to content

[Desktop] Fix unnecessary setting update#2301

Merged
huchenlei merged 4 commits intomainfrom
fix-window-style-loop
Jan 20, 2025
Merged

[Desktop] Fix unnecessary setting update#2301
huchenlei merged 4 commits intomainfrom
fix-window-style-loop

Conversation

@webfiltered
Copy link
Copy Markdown
Contributor

@webfiltered webfiltered commented Jan 20, 2025

  • Prevents setting change from being sent to desktop when nothing has changed.
  • Fixes infinite setting loop in Window style change desktop#601.
  • Fixes option display capitalisation.

┆Issue is synchronized with this Notion page by Unito

@webfiltered webfiltered changed the title Fix setting klobbering [Desktop] Fix unnecessary windowStyle setting update Jan 20, 2025
@webfiltered webfiltered changed the title [Desktop] Fix unnecessary windowStyle setting update [Desktop] Fix unnecessary setting update Jan 20, 2025
github-actions and others added 2 commits January 20, 2025 17:41
@huchenlei huchenlei merged commit f9be20f into main Jan 20, 2025
@huchenlei huchenlei deleted the fix-window-style-loop branch January 20, 2025 19:00
@huchenlei huchenlei added the Electron ComfyUI Desktop related label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Electron ComfyUI Desktop related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants