Fix HiDream-O1 LoRA loading (add model_lora_keys_unet branch)#14767
Fix HiDream-O1 LoRA loading (add model_lora_keys_unet branch)#14767yjy415 wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change adds support for the HiDreamO1 model type in the LoRA key mapping logic. A new conditional branch in Changes
Sequence Diagram(s)Not applicable — this change is a straightforward conditional key-mapping addition without new control flow between components. Related issues: None specified. Related PRs: None specified. Suggested labels: enhancement, LoRA Suggested reviewers: comfy-org maintainers familiar with LoRA key mapping logic Poem: A rabbit hopped through model code today, / Found HiDreamO1 without delay, / Three prefixes stitched with gentle care, / lycoris, transformer, model — laid bare, / Nine lines added, keys now align, / A tiny burrow dug just fine. 🐰 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Only put the prefix to get your loras working, if there are no loras using the other prefixes they are not necessary. |
HiDream-O1LoRAs trained by the community (including the training scripts distributed on ModelScope's AIGC hub) fail to load: every LoRA key emits[WARNING] lora key not loaded: model.language_model.layers...lines.This PR adds a
HiDreamO1branch that mirrors the existingHiDream/QwenImagebranches and registers the three standard prefix aliases (model.*,transformer.*,lycoris_*).