Skip to content

Add .onnx to supported model extensions#14736

Open
2023Anita wants to merge 1 commit into
Comfy-Org:masterfrom
2023Anita:2023Anita/model-paths/onnx-extension
Open

Add .onnx to supported model extensions#14736
2023Anita wants to merge 1 commit into
Comfy-Org:masterfrom
2023Anita:2023Anita/model-paths/onnx-extension

Conversation

@2023Anita

Copy link
Copy Markdown

Adds .onnx to the shared supported model extension set used by model folders.

This lets ONNX model files appear in existing model folder searches for workflows and custom nodes that expect to select them through ComfyUI's folder path helpers. It does not add any new loader behavior or network access.

Verification:

  • python3 -m py_compile folder_paths.py

Closes #14676

AI assistance was used to prepare this contribution, and the final change was reviewed before submission.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dedf8e62-b124-4d27-8ae0-1ad7e6ed983e

📥 Commits

Reviewing files that changed from the base of the PR and between 35c1470 and 837d176.

📒 Files selected for processing (1)
  • folder_paths.py

📝 Walkthrough

Walkthrough

This change modifies the supported_pt_extensions set in folder_paths.py to include the .onnx file extension, expanding the list of file extensions recognized as model-related files throughout the module.

Changes

File Change Summary
folder_paths.py Added .onnx to the supported_pt_extensions set

Sequence Diagram(s)

Not applicable for this change.

Compact metadata
Type: Enhancement
Files changed: 1
Lines changed: +1/-1
Estimated review effort: Low

Related issues: None specified

Related PRs: None specified

Suggested labels: enhancement, minor

Suggested reviewers: None specified

Poem
A rabbit hopped by with a byte in its paw,
Dropped ".onnx" in the set, without any flaw.
One line, one change, so tidy and small,
Yet now onnx files answer the call! 🐰

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: adding .onnx to supported model extensions.
Description check ✅ Passed The description matches the change and explains its effect on model folder searches.
Linked Issues check ✅ Passed The PR implements #14676 by adding .onnx to folder_paths.py so custom nodes can find ONNX models.
Out of Scope Changes check ✅ Passed The diff is limited to the requested extension set update with no unrelated code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please include .onnx in folder_paths.py

1 participant