feat: add bboxes input to Create Bounding Boxes node#14724
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR adds optional upstream ChangesCohort: Bboxes input support Sequence Diagram(s)sequenceDiagram
participant Caller
participant CreateBoundingBoxes
participant NormalizeIncomingBoxes
participant LastIncomingCache
Caller->>CreateBoundingBoxes: execute(width, height, editor_state, background, bboxes)
CreateBoundingBoxes->>NormalizeIncomingBoxes: normalize_incoming_boxes(bboxes)
NormalizeIncomingBoxes-->>CreateBoundingBoxes: incoming
CreateBoundingBoxes->>LastIncomingCache: compare incoming vs cached value (unique_id)
LastIncomingCache-->>CreateBoundingBoxes: changed / unchanged
CreateBoundingBoxes->>LastIncomingCache: update cache with incoming
CreateBoundingBoxes-->>Caller: NodeOutput with ui (input_bboxes if incoming present)
Estimated code review effort: High Related PRs: None identified from provided context. Suggested labels: enhancement, comfy_extras Suggested reviewers: None identified from provided context. Poem 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@comfy_extras/nodes_bounding_boxes.py`:
- Line 228: The bbox state handling in the node class is conflating “socket
present” with “non-empty list,” so empty lists from upstream or an intentionally
empty editor state get ignored. Update the logic around the incoming/editor
merge in the bounding-box node methods so presence is tracked separately from
list contents, and let an explicit empty list override the current canvas state
instead of falling back to the previous value. Use the existing bbox state
fields and merge path around the incoming cache/editor_state handling to
preserve clears correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c93a28e9-7f22-4723-b256-6ef8674754be
📒 Files selected for processing (1)
comfy_extras/nodes_bounding_boxes.py
2a38582 to
b82c8c7
Compare
Improved Create Bounding Boxes node with:
FE is
screenshot
2026-07-01.14-23-51.mp4